Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-04-30 14:37:46 +08:00
Code Packages Activity Actions
discourse/spec/system/page_objects/components
History
Exact
Martin Brennan bef35e2cd4
FIX: Handle cancel action in topic reply choice dialog (#35534) 
Steps to reproduce:

* Start drafting a reply to a topic
* Write some text.
* Navigate to a different topic while keeping the draft open
* Click reply on the composer and choose cancel in the modal asking
which topic you want to reply to.
* Write some more text.
* Copy the text you have written or memorize your input.
* Reload the page/ close the composer.
* Navigate back to the topic you replied to
* Open your draft.
* Everything written after clicking cancel is missing.

This was happening because we weren't doing anything on Cancel for
the topic reply choice dialog, and we were doing `disableDrafts` before
opening the dialog, so drafts never resumed.

The fix is to just save the current draft on cancel then turn on
draft saving again so the user can continue typing and delay the
question about "Which topic do you want to reply to?" until later.

c.f.
https://meta.discourse.org/t/draft-is-no-longer-automatically-saved-after-you-cancel-replying/386370

Also rename TopicLabelContent to TopicReplyChoiceDialog, it
is more specific and reflects what the component actually does.
2025-10-22 14:42:57 +10:00
..
navigation_menu UX: Add exact URL matching for sidebar section links (#34677) 2025-10-14 10:11:17 +08:00
review UX: Improve layout for reviewable flagged post in new UI (#33534) 2025-09-17 09:10:52 +08:00
about_page_site_activity.rb FEATURE: Add estimated number of global and EU visitors to the about page (#28382) 2024-08-21 00:03:42 +03:00
about_page_site_activity_item.rb FEATURE: Add estimated number of global and EU visitors to the about page (#28382) 2024-08-21 00:03:42 +03:00
about_page_users_list.rb DEV: Add admins and moderators sections to the redesigned /about page (#28273) 2024-08-12 16:23:44 +03:00
ace_editor.rb DEV: replace selenium driver with playwright (#31977) 2025-05-06 10:44:14 +02:00
admin_about_config_area_contact_information_card.rb DEV: Migrate about config area to Form Kit (#28021) 2024-07-25 19:07:38 +03:00
admin_about_config_area_general_settings_card.rb FEATURE: Add 'Community title' field to about config page (#29500) 2024-10-31 10:04:31 +03:00
admin_about_config_area_group_listing_card.rb DEV: Port the about page extra groups functionality into core (#32659) 2025-05-14 09:44:25 +08:00
admin_about_config_area_your_organization_card.rb DEV: Migrate about config area to Form Kit (#28021) 2024-07-25 19:07:38 +03:00
admin_changes_banner.rb FEATURE: Theme-owned color palettes (#32795) 2025-06-04 07:47:58 +03:00
admin_customize_theme_install_button.rb UX: Creating a new theme/component should redirect to theme edit route (#34353) 2025-08-19 11:30:44 +08:00
admin_filter_controls.rb FEATURE: Add reusable AdminFilterControls component, apply to plugins and reports (#33706) 2025-07-24 16:55:33 -04:00
admin_fonts_form.rb UX: split admin logo and fonts to separate pages (#32700) 2025-05-14 14:02:34 +08:00
admin_logo_form.rb UX: split admin logo and fonts to separate pages (#32700) 2025-05-14 14:02:34 +08:00
admin_theme_settings_editor.rb DEV: Rename fill_input -> set_input in AceEditor page object (#31825) 2025-03-14 22:16:53 +08:00
admin_theme_translations_settings_editor.rb FEATURE: add language picker for theme translations in admin UI (#26150) 2024-03-18 12:00:28 -04:00
base.rb DEV: Add basic system spec for discourse-reaction on post (#35029) 2025-09-30 10:29:34 +10:00
bookmark_menu.rb DEV: implements <DropdownMenu /> (#26917) 2024-05-08 09:08:42 +02:00
calendar_date_time_picker.rb DEV: Add more structure for admin plugin config nav (#26707) 2024-05-02 11:36:46 +10:00
category_badge.rb FEATURE: Bulk topic tagging allowing restricted operations on sole categories (#26602) 2024-04-12 13:10:14 +10:00
category_list.rb DEV: Add translation specs for navigating across categories (#35152) 2025-10-06 14:24:12 +08:00
category_permission_row.rb UX: Add group link to category permission row (#28560) 2024-08-28 16:11:16 +10:00
color_palette_editor.rb DEV: Allow pasting color codes with leading hash sign in palettes (#34512) 2025-08-27 15:52:20 +08:00
composer.rb DEV: Add client settled checks for system tests (#35230) 2025-10-10 11:03:18 +08:00
d_menu.rb UX: enhances messages dropdown with unread count (#33889) 2025-08-01 07:19:04 +08:00
d_page_header.rb FEATURE: Theme-owned color palettes (#32795) 2025-06-04 07:47:58 +03:00
d_select.rb FEATURE: Introduce new components listing page (#32164) 2025-04-08 17:58:29 +03:00
d_toggle_switch.rb FIX: Improve automation on/off toggle (#33482) 2025-08-14 10:16:20 +03:00
dialog.rb DEV: Add confirm_danger to Dialog page object (#26846) 2024-05-03 09:31:16 +10:00
drafts_menu.rb FIX: enable drafts dropdown on private categories (#32370) 2025-04-18 17:38:35 +04:00
emoji_picker.rb
empty_state.rb FEATURE: Always show All, Topics, and Replies subtabs for unified new (#35292) 2025-10-15 09:47:23 +10:00
fast_editor.rb
filter.rb FIX: bring back sidebar filter (#32837) 2025-05-22 13:44:25 +08:00
form_kit.rb FIX: Allow saving category when color attributes are 3-digits hex (#35119) 2025-10-02 14:33:30 +03:00
group-card.rb
home_logo.rb FEATURE: Dark/light mode selector (#31086) 2025-02-07 03:28:34 +03:00
interface_color_mode.rb FEATURE: Dark/light mode selector (#31086) 2025-02-07 03:28:34 +03:00
interface_color_selector.rb FEATURE: Color mode preference (#33875) 2025-07-31 08:17:02 +03:00
logo.rb DEV: Attempt to fix flaky search system test (#32053) 2025-03-28 11:16:43 +08:00
new_topic_list_toggle.rb FEATURE: Always show All, Topics, and Replies subtabs for unified new (#35292) 2025-10-15 09:47:23 +10:00
new_topic_list_toggle_tab.rb
notifications_tracking.rb DEV: replaces topic-notifications-options by DMenu (#30298) 2024-12-16 19:59:18 +01:00
photoswipe.rb FEATURE: Experimental Photoswipe Lightbox (#35109) 2025-10-16 12:24:11 +04:00
pikaday_calendar.rb DEV: replace selenium driver with playwright (#31977) 2025-05-06 10:44:14 +02:00
post.rb FIX: Mention with a status should open the user card (#33979) 2025-07-31 02:32:24 +03:00
private_message_map.rb UX: Merge the simplified topic map (#27964) 2024-07-22 19:42:29 -03:00
review_note_form.rb FIX: Persist reviewable notes when toggle tabs (#35495) 2025-10-21 10:23:41 +08:00
select_kit.rb FEATURE: improvements to ai conversation page (#33853) 2025-07-26 09:19:28 +10:00
sidebar_header_dropdown.rb
theme_translation_text_area.rb FEATURE: add language picker for theme translations in admin UI (#26150) 2024-03-18 12:00:28 -04:00
toasts.rb DEV: Fix draft spec (#34544) 2025-08-27 16:43:13 +10:00
tooltips.rb DEV: adds a tooltip system spec component (#28275) 2024-08-08 14:02:00 +02:00
topic_list.rb DEV: Add translation specs for navigating across categories (#35152) 2025-10-06 14:24:12 +08:00
topic_list_controls.rb
topic_list_header.rb FEATURE: Use new topic bulk actions dropdown on search page (#27303) 2024-06-07 10:41:42 +10:00
topic_map.rb UX: Merge the simplified topic map (#27964) 2024-07-22 19:42:29 -03:00
topic_query_filter.rb DEV: Convert FilterTips to use DMenu and refactor components (#33999) 2025-08-05 12:10:40 +10:00
topic_reply_choice_dialog.rb FIX: Handle cancel action in topic reply choice dialog (#35534) 2025-10-22 14:42:57 +10:00
topic_view.rb DEV: replaces topic-notifications-options by DMenu (#30298) 2024-12-16 19:59:18 +01:00
uppy_image_uploader.rb DEV: Update PageObjects::Components::FormKit#submit to click submit (#34740) 2025-09-05 10:21:12 +08:00
user_card.rb FIX: Mention with a status should open the user card (#33979) 2025-07-31 02:32:24 +03:00
user_menu.rb UX: Notification panel update (#33795) 2025-07-24 11:21:39 -05:00
welcome_banner.rb UX: add welcome banner text color setting (#34657) 2025-09-24 15:19:40 +08:00