mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-01 05:51:37 +08:00
337cfeabbb
I wanted to have a more specific error when there's an unexpected server error (5XX). Turns out the existing error differentiation (between not_found and invalid) was not working, because the shape of e is not what the developer expected. This PR fixes that and adds another message for unexpected errors.
66 lines
1.9 KiB
Ruby
66 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Impersonation", type: :system do
|
|
fab!(:admin)
|
|
fab!(:user)
|
|
|
|
let(:dialog) { PageObjects::Components::Dialog.new }
|
|
|
|
before do
|
|
SiteSetting.experimental_impersonation = true
|
|
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "allows you to start and stop impersonating with the click of a button" do
|
|
visit("/admin/users/#{user.id}/#{user.username}")
|
|
|
|
page.find(".btn-impersonate").click
|
|
|
|
expect(page).to have_current_path("/")
|
|
expect(page).to have_css(
|
|
".impersonation-notice",
|
|
text: I18n.t("js.impersonation.notice", username: user.username),
|
|
)
|
|
|
|
visit("/latest")
|
|
|
|
page.find(".impersonation-notice .btn-danger").click
|
|
|
|
expect(page).to have_current_path("/")
|
|
expect(page).to have_no_css(".impersonation-notice")
|
|
end
|
|
|
|
it "shows a helpful error when the user is not found" do
|
|
Admin::ImpersonateController.any_instance.stubs(:create).raises(Discourse::NotFound)
|
|
|
|
visit("/admin/users/#{user.id}/#{user.username}")
|
|
|
|
page.find(".btn-impersonate").click
|
|
|
|
expect(dialog).to be_open
|
|
expect(dialog).to have_content(I18n.t("admin_js.admin.impersonate.not_found"))
|
|
end
|
|
|
|
it "shows a helpful error when impersonation of that user is not allowed" do
|
|
Admin::ImpersonateController.any_instance.stubs(:create).raises(Discourse::InvalidAccess)
|
|
|
|
visit("/admin/users/#{user.id}/#{user.username}")
|
|
|
|
page.find(".btn-impersonate").click
|
|
|
|
expect(dialog).to be_open
|
|
expect(dialog).to have_content(I18n.t("admin_js.admin.impersonate.invalid"))
|
|
end
|
|
|
|
it "shows a helpful error when there's an unexpected server error" do
|
|
Admin::ImpersonateController.any_instance.stubs(:create).raises(StandardError)
|
|
|
|
visit("/admin/users/#{user.id}/#{user.username}")
|
|
|
|
page.find(".btn-impersonate").click
|
|
|
|
expect(dialog).to be_open
|
|
expect(dialog).to have_content(I18n.t("admin_js.admin.impersonate.error"))
|
|
end
|
|
end
|
