mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-01 05:39:09 +08:00
e63716d650
The change made in #31854 introduced a regression when editing groups, preventing saving when no auto membership e-mail domains are entered. This change fixes that and adds a system test.
90 lines
2.5 KiB
Ruby
90 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Group", type: :system do
|
|
let(:group_page) { PageObjects::Pages::Group.new }
|
|
let(:group_index_page) { PageObjects::Pages::GroupIndex.new }
|
|
let(:group_form_page) { PageObjects::Pages::GroupForm.new }
|
|
let(:dialog) { PageObjects::Components::Dialog.new }
|
|
fab!(:admin)
|
|
fab!(:group)
|
|
|
|
before { sign_in(admin) }
|
|
|
|
describe "create a group" do
|
|
context "when there are no existing users matching the auto e-mail domains" do
|
|
it "creates a new group" do
|
|
group_index_page.visit
|
|
group_index_page.click_new_group
|
|
|
|
group_form_page.fill_in("name", with: "illuminati")
|
|
group_form_page.fill_in("full_name", with: "The Illuminati")
|
|
|
|
expect(group_form_page).to have_css(".tip.good")
|
|
|
|
group_form_page.add_automatic_email_domain("illumi.net")
|
|
group_form_page.click_save
|
|
|
|
expect(page).to have_current_path("/g/illuminati")
|
|
end
|
|
end
|
|
|
|
context "when there are existing users matching the auto e-mail domains" do
|
|
before { Fabricate(:user, email: "ted@illumi.net") }
|
|
|
|
it "notifies about automatic members and creates a new group" do
|
|
group_index_page.visit
|
|
group_index_page.click_new_group
|
|
|
|
group_form_page.fill_in("name", with: "illuminati")
|
|
group_form_page.fill_in("full_name", with: "The Illuminati")
|
|
|
|
expect(group_form_page).to have_css(".tip.good")
|
|
|
|
group_form_page.add_automatic_email_domain("illumi.net")
|
|
|
|
group_form_page.click_save
|
|
expect(dialog).to be_open
|
|
expect(dialog).to have_content(
|
|
I18n.t(
|
|
"admin_js.admin.groups.manage.membership.automatic_membership_user_count",
|
|
count: 1,
|
|
),
|
|
)
|
|
|
|
dialog.click_no
|
|
expect(page).to have_current_path("/g/custom/new")
|
|
|
|
group_form_page.click_save
|
|
expect(dialog).to be_open
|
|
|
|
dialog.click_yes
|
|
expect(page).to have_current_path("/g/illuminati")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "update a group" do
|
|
it "creates a new group" do
|
|
group_page.visit(group)
|
|
|
|
group_page.click_manage
|
|
group_page.click_membership
|
|
|
|
group_page.fill_in("title", with: "The Illuminati")
|
|
|
|
group_page.click_save
|
|
|
|
expect(group_page).to have_css(".group-manage-save-button span", text: "Saved!")
|
|
end
|
|
end
|
|
|
|
describe "delete a group" do
|
|
it "redirects to groups index page" do
|
|
group_page.visit(group)
|
|
|
|
group_page.delete_group
|
|
|
|
expect(page).to have_current_path("/g")
|
|
end
|
|
end
|
|
end
|
