mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-04-30 21:10:03 +08:00
2b7835d02a
This commitreworks the validation and handling of color pickers in the category edit page so they're simpler and more predictable. In particular: * It no longer attempts to "autocomplete" 3-digits hex values to the equivalent 6-digits format -- we now accept both 3 and 6 digits formats * It no longer disables the save button if the input color value is invalid. The save button is always clickable, and if the admin attempts to save with an invalid color value, the form will display errors explaining which input is invalid and what's wrong with the color value Internal topic: t/163062.
73 lines
2.6 KiB
Ruby
73 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Edit Category General", type: :system do
|
|
fab!(:admin)
|
|
fab!(:category)
|
|
let(:category_page) { PageObjects::Pages::Category.new }
|
|
let(:form) { PageObjects::Components::FormKit.new(".form-kit") }
|
|
before { sign_in(admin) }
|
|
|
|
context "when changing background color" do
|
|
it "displays an error when the hex code is invalid" do
|
|
category_page.visit_general(category)
|
|
|
|
form.field("color").component.find("input.hex-input").fill_in(with: "ABZ")
|
|
category_page.save_settings
|
|
expect(form.field("color")).to have_errors(
|
|
I18n.t("js.category.color_validations.non_hexdecimal"),
|
|
)
|
|
|
|
form.field("color").component.find("input.hex-input").fill_in(with: "")
|
|
category_page.save_settings
|
|
expect(form.field("color")).to have_errors(
|
|
I18n.t("js.category.color_validations.cant_be_empty"),
|
|
)
|
|
|
|
form.field("color").component.find("input.hex-input").fill_in(with: "A")
|
|
category_page.save_settings
|
|
expect(form.field("color")).to have_errors(
|
|
I18n.t("js.category.color_validations.incorrect_length"),
|
|
)
|
|
end
|
|
|
|
it "saves successfully when the hex code is valid" do
|
|
category_page.visit_general(category)
|
|
|
|
form.field("color").component.find("input.hex-input").fill_in(with: "AB1")
|
|
category_page.save_settings
|
|
expect(form.field("color")).to have_no_errors
|
|
end
|
|
end
|
|
|
|
context "when changing text color" do
|
|
it "displays an error when the hex code is invalid" do
|
|
category_page.visit_general(category)
|
|
|
|
form.field("text_color").component.find("input.hex-input").fill_in(with: "ABZ")
|
|
category_page.save_settings
|
|
expect(form.field("text_color")).to have_errors(
|
|
I18n.t("js.category.color_validations.non_hexdecimal"),
|
|
)
|
|
|
|
form.field("text_color").component.find("input.hex-input").fill_in(with: "")
|
|
category_page.save_settings
|
|
expect(form.field("text_color")).to have_errors(
|
|
I18n.t("js.category.color_validations.cant_be_empty"),
|
|
)
|
|
|
|
form.field("text_color").component.find("input.hex-input").fill_in(with: "A")
|
|
category_page.save_settings
|
|
expect(form.field("text_color")).to have_errors(
|
|
I18n.t("js.category.color_validations.incorrect_length"),
|
|
)
|
|
end
|
|
|
|
it "saves successfully when the hex code is valid" do
|
|
category_page.visit_general(category)
|
|
|
|
form.field("text_color").component.find("input.hex-input").fill_in(with: "AB1")
|
|
category_page.save_settings
|
|
expect(form.field("text_color")).to have_no_errors
|
|
end
|
|
end
|
|
end
|
