mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-05 12:46:33 +08:00
822e5d6d95
The `choices` are actually expected to be sorted alphabetically, and the tag fabricator might generate three tags like `["tag9", "tag10", "tag11"]` while we expect it to also sort alphabetically as `["tag10", "tag11", "tag9"]`
124 lines
4.3 KiB
Ruby
124 lines
4.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe FormTemplate, type: :model do
|
|
it "can't have duplicate names" do
|
|
Fabricate(:form_template, name: "Bug Report", template: "- type: input\n id: name")
|
|
t = Fabricate.build(:form_template, name: "Bug Report", template: "- type: input\n id: name")
|
|
expect(t.save).to eq(false)
|
|
t = Fabricate.build(:form_template, name: "Bug Report", template: "- type: input\n id: name")
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(I18n.t("errors.messages.taken"))
|
|
expect(described_class.count).to eq(1)
|
|
end
|
|
|
|
context "when length validations set in SiteSetting" do
|
|
before do
|
|
SiteSetting.max_form_template_content_length = 50
|
|
SiteSetting.max_form_template_title_length = 5
|
|
end
|
|
|
|
it "can't exceed max title length" do
|
|
t = Fabricate.build(:form_template, name: "Bug Report", template: "- type: input\n id: name")
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(
|
|
"Name #{I18n.t("errors.messages.too_long", count: SiteSetting.max_form_template_title_length)}",
|
|
)
|
|
end
|
|
|
|
it "can't exceed max content length" do
|
|
t =
|
|
Fabricate.build(
|
|
:form_template,
|
|
name: "Bug",
|
|
template: "- type: input\n id: name-that-is-really-long-to-make-the-template-longer",
|
|
)
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(
|
|
"Template #{I18n.t("errors.messages.too_long", count: SiteSetting.max_form_template_content_length)}",
|
|
)
|
|
end
|
|
|
|
it "should update validation limits when the site setting has been changed" do
|
|
SiteSetting.max_form_template_content_length = 100
|
|
SiteSetting.max_form_template_title_length = 100
|
|
|
|
t =
|
|
Fabricate.build(
|
|
:form_template,
|
|
name: "Bug Report",
|
|
template: "- type: input\n id: name-that-is-really-long-to-make-the-template-longer",
|
|
)
|
|
|
|
expect(t.save).to eq(true)
|
|
end
|
|
end
|
|
|
|
it "can't have an invalid yaml template" do
|
|
template = "- type: checkbox\nattributes; bad"
|
|
t = Fabricate.build(:form_template, name: "Feature Request", template: template)
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(I18n.t("form_templates.errors.invalid_yaml"))
|
|
end
|
|
|
|
it "must have a supported type" do
|
|
template = "- type: fancy\n id: something"
|
|
t = Fabricate.build(:form_template, name: "Fancy Template", template: template)
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(
|
|
I18n.t(
|
|
"form_templates.errors.invalid_type",
|
|
type: "fancy",
|
|
valid_types: FormTemplateYamlValidator::ALLOWED_TYPES.join(", "),
|
|
),
|
|
)
|
|
end
|
|
|
|
it "must have a type property" do
|
|
template = "- hello: world\n id: something"
|
|
t = Fabricate.build(:form_template, name: "Basic Template", template: template)
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(I18n.t("form_templates.errors.missing_type"))
|
|
end
|
|
|
|
it "must have a id property" do
|
|
template = "- type: checkbox"
|
|
t = Fabricate.build(:form_template, name: "Basic Template", template: template)
|
|
expect(t.save).to eq(false)
|
|
expect(t.errors.full_messages.first).to include(I18n.t("form_templates.errors.missing_id"))
|
|
end
|
|
|
|
describe "#process!" do
|
|
fab!(:admin)
|
|
fab!(:tag1, :tag)
|
|
fab!(:tag2, :tag)
|
|
fab!(:tag3, :tag)
|
|
fab!(:tag4, :tag)
|
|
fab!(:tag5, :tag)
|
|
fab!(:tag_group) { Fabricate(:tag_group, tags: [tag1, tag2, tag3]) }
|
|
fab!(:tag_group2) { Fabricate(:tag_group, tags: [tag4, tag5]) }
|
|
|
|
it "automatically adds tags choices to the template" do
|
|
template = <<~YAML
|
|
- type: tag-chooser
|
|
id: tag-chooser
|
|
tag_group: "#{tag_group.name}"
|
|
- type: tag-chooser
|
|
id: tag-chooser2
|
|
tag_group: "#{tag_group2.name}"
|
|
attributes:
|
|
multiple: true
|
|
YAML
|
|
|
|
form_template = Fabricate(:form_template, template: template)
|
|
guardian = Guardian.new(admin)
|
|
|
|
form_template.process!(guardian)
|
|
|
|
g1, g2 = YAML.safe_load(form_template.template)
|
|
|
|
expect(g1["choices"]).to eq([tag1.name, tag2.name, tag3.name].sort)
|
|
expect(g2["attributes"]["tag_group"]).to eq(tag_group2.name)
|
|
expect(g2["attributes"]["multiple"]).to eq(true)
|
|
end
|
|
end
|
|
end
|
