mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
65d162b350`INTERACTIVE_SELECTOR` includes "details" so that clicking a `<details>`
inside a spoiler expands it without also re-blurring the surrounding
spoiler. But because `closest()` walks up the DOM tree, every click
inside a `[spoiler]` that happens to be nested inside a `[details]` also
matches `closest("details")` against the parent `<details>` — making
such a spoiler impossible to re-blur once revealed.
Fix: scope the `closest()` result with `element.contains(...)` so only
interactive ancestors that live inside the spoiler block re-blurring.
Interactive ancestors above the spoiler are ignored.
Tests cover both directions: a spoiler-inside-details can re-blur, and
clicking an interactive descendant of a revealed spoiler still does not
re-blur it.
Context:
https://meta.discourse.org/t/spoilers-don-t-toggle-when-inside-details/194499
|
||
|---|---|---|
| .. | ||
| acceptance | ||
| integration | ||
| unit/lib | ||
