mirror of
https://github.com/discourse/discourse.git
synced 2026-08-09 21:45:25 +08:00
1fd0efc849
Temporary instrumentation to diagnose the ScriptTerminatedError that appears in single-threaded mode after the mini_racer 0.21.0 -> 0.21.3 upgrade (e.g. spec/system/table_builder_spec.rb, raised from PrettyText.cook during fab!/create_post setup). Local reproduction shows no genuine 25s slowdown: idle cooks are ~19ms on both versions, and the per-callback regression in single-threaded mode (0.21.1+ routes js->ruby callbacks through the dedicated runner thread instead of inline, ~30x slower per callback) is nowhere near enough to hit the 25s watchdog. The open question is whether CI is hitting the watchdog at all, or whether the cook is being aborted instantly — 0.21.3 wires an rb_nogvl unblock function that calls v8_terminate_execution on any interrupt, where 0.21.0 passed a NULL ubf and deferred interrupts until the eval finished. This prepends to MiniRacer::Context and, on every ScriptTerminatedError, logs the elapsed time of that eval/call (≈25000ms => real watchdog timeout; tiny => instant abort) plus a backtrace snapshot of every live thread, and logs stop/dispose so a concurrent terminator on the shared context is visible. Verified locally: transparent to normal cooks, fires on forced termination. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| 000-active_record.rb | ||
| 000-development_reload_warnings.rb | ||
| 000-mini_racer.rb | ||
| 000-mini_sql.rb | ||
| 000-pg_connection_patch.rb | ||
| 000-post_migration.rb | ||
| 000-trace_pg_connections.rb | ||
| 000-zeitwerk.rb | ||
| 001-redis.rb | ||
| 002-freedom_patches.rb | ||
| 002-rails_failover.rb | ||
| 004-message_bus.rb | ||
| 005-site_settings.rb | ||
| 006-mini_profiler.rb | ||
| 008-rack-cors.rb | ||
| 009-omniauth.rb | ||
| 012-category_types.rb | ||
| 012-web_hook_events.rb | ||
| 014-track-setting-changes.rb | ||
| 015-track-upcoming-change-toggle.rb | ||
| 099-anon-cache.rb | ||
| 099-drain_pool.rb | ||
| 099-mini_racer_debug.rb | ||
| 100-active-support-type-extensions.rb | ||
| 100-anonymous_actions.rb | ||
| 100-custom-timezones.rb | ||
| 100-flags.rb | ||
| 100-i18n.rb | ||
| 100-logster.rb | ||
| 100-oj.rb | ||
| 100-onebox_options.rb | ||
| 100-quiet_logger.rb | ||
| 100-regex-timeout.rb | ||
| 100-secret_token.rb | ||
| 100-session_store.rb | ||
| 100-sidekiq.rb | ||
| 100-silence_logger.rb | ||
| 100-strong_parameters.rb | ||
| 100-verify_config.rb | ||
| 100-wrap_parameters.rb | ||
| 101-lograge.rb | ||
| 102-truncate-logs.rb | ||
| 200-first_middlewares.rb | ||
| 300-nested-replies.rb | ||
| 300-perf.rb | ||
| 400-deprecations.rb | ||
| 999-themes.rb | ||
| assets.rb | ||
| filter_parameter_logging.rb | ||
