mirror of
https://github.com/discourse/discourse.git
synced 2026-08-12 05:37:26 +08:00
793d88efedThe discourse_test image installs the locked bundler into vendor/bundle and then deletes the gem cache. bundler's CHECKSUMS line is computed from the cached .gem, so when BUNDLED WITH points at a bundler that only lives in the stripped vendor/bundle cache, `bundle lock --add-checksums` silently drops the line and the lockfile check fails. Removing the prebuilt bundler makes `bundle install` auto-install it, which re-caches the .gem the checksum step needs. This commit also improves the checksums CI step, so that any problematic diff is printed to the console (like we do for annotations & db structure steps)
105 lines
3.1 KiB
YAML
Vendored
105 lines
3.1 KiB
YAML
Vendored
name: Linting
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- main
|
|
|
|
concurrency:
|
|
group: linting-${{ format('{0}-{1}', github.head_ref || github.run_number, github.job) }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
build:
|
|
if: github.event_name == 'pull_request' || github.repository != 'discourse/discourse-private-mirror'
|
|
name: run
|
|
runs-on: ${{ (github.repository_owner == 'discourse' && 'cdck-linux-8-core') || 'ubuntu-latest' }}
|
|
container: discourse/discourse_test:release
|
|
timeout-minutes: 30
|
|
|
|
steps:
|
|
- name: Set working directory owner
|
|
run: chown root:root .
|
|
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
fetch-depth: 1
|
|
|
|
- name: Setup Git
|
|
run: |
|
|
git config --global user.email "ci@ci.invalid"
|
|
git config --global user.name "Discourse CI"
|
|
|
|
- name: Symlink vendor/bundle from image
|
|
run: |
|
|
ln -s /var/www/discourse/vendor/bundle vendor/bundle
|
|
|
|
- name: Setup gems
|
|
run: |
|
|
bundle config --local path vendor/bundle
|
|
bundle config --local deployment true
|
|
bundle config --local without development
|
|
bundle config --local lockfile_checksums true
|
|
# Drop the prebuilt bundler so `bundle install` re-fetches it, caching the .gem its checksum line needs
|
|
rm -rf vendor/bundle/ruby/*/gems/bundler-* vendor/bundle/ruby/*/specifications/bundler-*
|
|
bundle install --jobs 4
|
|
bundle clean
|
|
|
|
- name: pnpm install
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Bundler checksums
|
|
if: ${{ !cancelled() }}
|
|
shell: bash
|
|
run: |
|
|
bundle lock --add-checksums
|
|
bundle lock --normalize-platforms
|
|
if [[ $(git status -s Gemfile.lock) ]]; then
|
|
echo "Gemfile.lock is not up to date. To resolve, run:"
|
|
echo " bundle lock --add-checksums && bundle lock --normalize-platforms"
|
|
echo
|
|
echo "Or manually apply the diff printed below:"
|
|
echo "---------------------------------------------"
|
|
git -c color.ui=always diff Gemfile.lock
|
|
exit 1
|
|
fi
|
|
|
|
- name: Rubocop
|
|
if: ${{ !cancelled() }}
|
|
run: bundle exec rubocop
|
|
|
|
- name: syntax_tree
|
|
if: ${{ !cancelled() }}
|
|
run: |
|
|
set -E
|
|
bundle exec stree check Gemfile $(git ls-files '*.rb') $(git ls-files '*.rake') $(git ls-files '*.thor')
|
|
|
|
- name: ESLint
|
|
if: ${{ !cancelled() }}
|
|
run: pnpm lint:js
|
|
|
|
- name: Types
|
|
if: ${{ !cancelled() }}
|
|
run: pnpm lint:types
|
|
|
|
- name: Prettier
|
|
if: ${{ !cancelled() }}
|
|
run: |
|
|
pnpm prettier -v
|
|
pnpm lint:prettier
|
|
|
|
- name: Stylelint
|
|
if: ${{ !cancelled() }}
|
|
run: pnpm lint:css
|
|
|
|
- name: English locale lint (core)
|
|
if: ${{ !cancelled() }}
|
|
run: bundle exec ruby script/i18n_lint.rb "config/**/locales/{client,server}.en.yml"
|
|
|
|
- name: English locale lint (core plugins)
|
|
if: ${{ !cancelled() }}
|
|
run: bundle exec ruby script/i18n_lint.rb "plugins/**/locales/{client,server}.en.yml"
|
