mirror of
https://github.com/discourse/discourse.git
synced 2026-03-03 22:05:52 +08:00
0070b55cdf
We notify admins both when an upcoming change is available for preview (at promotion status - 1) and when an upcoming change is automatically promoted. There are cases where multiple changes might be deployed at the same time, and we want to avoid sending multiple notifications to admins in a short period of time. This PR consolidates the notifications for both events into a single notification that includes all relevant changes. So for new upcoming changes, admins will receive a single notification that lists all the changes that are now available for preview. For automatic promotions, admins will receive a single notification that lists all the changes that were automatically promoted. In addition, this PR follows up on https://github.com/discourse/discourse/pull/38051 and directly links the notifications to a filtered list of upcoming changes by setting name. <img width="338" alt="image" src="https://github.com/user-attachments/assets/6febc7d7-0122-4f3b-8cbe-04d03721a709" /> <img width="332" alt="image" src="https://github.com/user-attachments/assets/46f2f886-8a6f-46f5-8038-bce3305d788f" /> ### Testing * Start with a fresh DB * Make sure `upcoming_change_verbose_logging` and `enable_upcoming_changes` are true * Choose a couple of upcoming changes and update their statuses in `site_settings.yml` to `beta` * Log in to the site and go to http://localhost:4200/sidekiq/scheduler and find the CheckUpcomingChanges job and run it * You should receive a notification for the changes becoming available, do not read the notification * Change another upcoming change to beta and run the job again * You should not get another notification, the third change should be merged into the first notification * Now update some of the same changes to `stable` status * Run the job again * You should get a new notification saying the changes were automatically enabled * Now update another of the same changes to `stable` status * You should not get another notification, the third change should be merged into the notification for enabled changes --------- Co-authored-by: awesomerobot <kris.aubuchon@discourse.org> |
||
|---|---|---|
| .. | ||
| fontawesome | ||
| discourse-additional.svg | ||
