2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-03-03 23:54:20 +08:00
discourse/spec/system/signup_spec.rb
Ted Johansson ea0555eedf
FIX: Exclude fields hidden on sign-up from invite signup form (#35405)
In #34672 we added the ability to hide user fields from the sign-up form. However, we didn't exclude these from the slightly different signup form used when you are invited by another user.

This commit adds a regression test and applies the same treatment to this special version of the form.
2025-10-15 16:06:31 +08:00

445 lines
14 KiB
Ruby

# frozen_string_literal: true
shared_examples "signup scenarios" do
let(:signup_page) { PageObjects::Pages::Signup.new }
let(:login_page) { PageObjects::Pages::Login.new }
let(:invite_form) { PageObjects::Pages::InviteForm.new }
let(:activate_account) { PageObjects::Pages::ActivateAccount.new }
let(:composer) { PageObjects::Components::Composer.new }
let(:invite) { Fabricate(:invite) }
let(:topic) { Fabricate(:topic, title: "Super cool topic") }
context "when anyone can create an account" do
before { Jobs.run_immediately! }
it "can signup" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
end
it "can signup and activate account" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
mail = ActionMailer::Base.deliveries.first
expect(mail.to).to contain_exactly(invite.email)
activation_link = mail.body.to_s[%r{/u/activate-account/\S+}]
visit activation_link
activate_account.click_activate_account
activate_account.click_continue
expect(page).to have_current_path("/")
expect(page).to have_css(".header-dropdown-toggle.current-user")
end
it "can access 2FA preferences screen after signing up and activating account" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
mail = ActionMailer::Base.deliveries.first
expect(mail.to).to contain_exactly(invite.email)
activation_link = mail.body.to_s[%r{/u/activate-account/\S+}]
visit activation_link
activate_account.click_activate_account
activate_account.click_continue
expect(page).to have_css(".header-dropdown-toggle.current-user")
visit "/u/john/preferences/security"
find(".btn-second-factor").click
expect(page).to have_css(".user-preferences.second-factor")
end
it "redirects to the topic the user was invited to after activating account" do
TopicInvite.create!(invite: invite, topic: topic)
invite_form.open(invite.invite_key)
invite_form.fill_username("john")
invite_form.fill_password("supersecurepassword")
expect(invite_form).to have_valid_fields
invite_form.click_create_account
expect(invite_form).to have_successful_message
mail = ActionMailer::Base.deliveries.first
expect(mail.to).to contain_exactly(invite.email)
activation_link = mail.body.to_s[%r{/u/activate-account/\S+}]
visit activation_link
activate_account.click_activate_account
expect(page).to have_current_path("/t/#{topic.slug}/#{topic.id}")
end
it "redirects to a new-topic after signin and keeps the query" do
category = Fabricate(:category)
SiteSetting.create_topic_allowed_groups = "0"
visit "/new-topic?category_id=#{category.id}"
signup_page
.open
.fill_email("johndoe@awesomeemail.com")
.fill_username("john11122")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
mail = ActionMailer::Base.deliveries.first
activation_link = mail.body.to_s[%r{/u/activate-account/\S+}]
visit activation_link
activate_account.click_activate_account
expect(page).to have_current_path("/c/#{category.id}")
expect(composer).to be_opened
end
it "cannot signup with a common password" do
signup_page.open.fill_email(invite.email).fill_username("john").fill_password("0123456789")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(signup_page).to have_content(
I18n.t("activerecord.errors.models.user_password.attributes.password.common"),
)
end
context "with invite code" do
before { SiteSetting.invite_code = "cupcake" }
it "can signup with valid code" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
.fill_code("cupcake")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
end
it "cannot signup with invalid code" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
.fill_code("pudding")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(signup_page).to have_content(I18n.t("login.wrong_invite_code"))
expect(signup_page).to have_no_css(".account-created")
end
end
context "when there are required user fields" do
before do
Fabricate(
:user_field,
name: "Occupation",
requirement: "on_signup",
description: "What you do for work",
)
end
it "can signup when filling the custom field" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
.fill_custom_field("Occupation", "Jedi")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
end
it "cannot signup without filling the custom field" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_content("What you do for work")
signup_page.click_create_account
expect(signup_page).to have_content(I18n.t("js.user_fields.required", name: "Occupation"))
expect(signup_page).to have_no_css(".account-created")
expect(signup_page).to have_css(".tip.bad", text: "Please enter a value for \"Occupation\"")
end
end
context "when user requires approval" do
before do
SiteSetting.must_approve_users = true
SiteSetting.auto_approve_email_domains = "awesomeemail.com"
end
it "can signup but cannot login until approval" do
signup_page
.open
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
wait_for(timeout: 5) { User.find_by(username: "john") != nil }
expect(page).to have_current_path("/u/account-created")
visit "/"
login_page.open
login_page.fill_username("john")
login_page.fill_password("supersecurepassword")
login_page.click_login
expect(login_page).to have_content(I18n.t("login.not_approved"))
user = User.find_by(username: "john")
user.update!(approved: true)
EmailToken.confirm(Fabricate(:email_token, user: user).token)
login_page.click_login
expect(page).to have_current_path("/")
expect(page).to have_css(".header-dropdown-toggle.current-user")
end
it "can login directly when using an auto approved email" do
signup_page
.open
.fill_email("johndoe@awesomeemail.com")
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/u/account-created")
user = User.find_by(username: "john")
EmailToken.confirm(Fabricate(:email_token, user:).token)
visit "/"
login_page.open.fill_username("john").fill_password("supersecurepassword").click_login
expect(page).to have_current_path("/")
expect(page).to have_css(".header-dropdown-toggle.current-user")
end
end
context "when site has subfolder install" do
before { set_subfolder "/discuss" }
it "can signup and activate account" do
visit("/discuss/signup")
signup_page
.fill_email(invite.email)
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_fields
signup_page.click_create_account
expect(page).to have_current_path("/discuss/u/account-created")
mail = ActionMailer::Base.deliveries.first
expect(mail.to).to contain_exactly(invite.email)
activation_link = mail.body.to_s[%r{\S+/u/activate-account/\S+}]
visit activation_link
activate_account.click_activate_account
activate_account.click_continue
expect(page).to have_current_path("/discuss/")
expect(page).to have_css(".header-dropdown-toggle.current-user")
end
end
end
context "when the email domain is blocked" do
before do
SiteSetting.hide_email_address_taken = false
SiteSetting.blocked_email_domains = "example.com"
end
it "cannot signup" do
signup_page
.open
.fill_email("blocked@example.com")
.fill_username("john")
.fill_password("supersecurepassword")
expect(signup_page).to have_valid_username
expect(signup_page).to have_valid_password
expect(signup_page).to have_content(I18n.t("user.email.not_allowed"))
end
end
context "when site is invite only" do
before { SiteSetting.invite_only = true }
it "cannot open the signup page" do
signup_page.open
expect(signup_page).to be_closed
expect(page).to have_no_css(".sign-up-button")
login_page.open_from_header
expect(login_page).to have_no_css("#new-account-link")
end
it "can signup with invite link" do
invite = Fabricate(:invite)
visit "/invites/#{invite.invite_key}?t=#{invite.email_token}"
find("#new-account-password").fill_in(with: "supersecurepassword")
find("#new-account-username").fill_in(with: "johndoe")
find(".username-input").has_css?("#username-validation.good")
find(".create-account__password-tip-validation").has_css?("#password-validation.good")
find(".invitation-cta__accept").click
expect(page).to have_current_path("/")
expect(page).to have_css(".header-dropdown-toggle.current-user")
end
end
it "correctly loads the invites page" do
inviter = Fabricate(:user)
invite = Fabricate(:invite, invited_by: inviter)
Fabricate(:user_field, name: "test", show_on_signup: false)
visit "/invites/#{invite.invite_key}?t=#{invite.email_token}"
expect(page).to have_css(".invited-by .user-info[data-username='#{inviter.username}']")
expect(page).to have_no_css(".user-field-test")
find(".invitation-cta__sign-in").click
expect(page).to have_css("#login-form")
page.go_back
expect(page).to have_css(".invited-by .user-info[data-username='#{inviter.username}']")
end
describe "full name field" do
context "when full_name_requirement is optional_at_signup" do
before { SiteSetting.full_name_requirement = "optional_at_signup" }
context "when login_required is true" do
before { SiteSetting.login_required = true }
it "displays the name field" do
signup_page.open
expect(signup_page).to have_name_input
end
end
context "when enable_names is false" do
before { SiteSetting.enable_names = false }
it "hides the name field" do
signup_page.open
expect(signup_page).to have_name_input
end
end
end
context "when full_name_requirement is hidden_at_signup" do
before { SiteSetting.full_name_requirement = "hidden_at_signup" }
it "hides the name field" do
signup_page.open
expect(signup_page).to have_no_name_input
end
end
context "when full_name_requirement is required_at_signup" do
before { SiteSetting.full_name_requirement = "required_at_signup" }
it "displays the name field" do
signup_page.open
expect(signup_page).to have_name_input
end
context "when enable_names is false" do
before { SiteSetting.enable_names = false }
it "hides the name field" do
signup_page.open
expect(signup_page).to have_name_input
end
end
end
end
describe "user custom fields" do
it "shows tips if required but not selected" do
user_field_text = Fabricate(:user_field)
user_field_dropdown = Fabricate(:user_field_dropdown)
signup_page.open
find(".signup-page-cta__signup").click
expect(signup_page).to have_content(
I18n.t("js.user_fields.required", name: user_field_text.name),
)
expect(signup_page).to have_content(
I18n.t("js.user_fields.required_select", name: user_field_dropdown.name),
)
end
it "does not show fields that are configured hidden on signup" do
Fabricate(:user_field, name: "test", show_on_signup: false)
signup_page.open
expect(signup_page).to have_no_css(".user-field-test")
end
end
end
describe "Signup", type: :system do
context "when desktop" do
include_examples "signup scenarios"
end
context "when mobile", mobile: true do
include_examples "signup scenarios"
end
end