mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-06-18 21:54:48 +08:00
63c4950c90
## What Draft spike for rendering nested replies through the normal topic route/controller/template (`/t/:slug/:id[/post_number]`) instead of a separate Ember `/n/...` browser page route. This keeps `/n/...` for internal JSON/API endpoints and legacy browser redirects, while using the canonical topic route for user-facing nested topic navigation. ## Changes - Add nested-topic loading/setup to `topic.fromParams` so `/t/...` can render the nested tree. - Render `<Nested>` from the topic template when the topic is in nested mode. - Keep the nested controller as the nested tree state owner, bridged from the topic route/controller. - Redirect legacy client-side `/n/...` browser routes to the corresponding `/t/...` routes. - Preserve nested context depth through model processing, controller state, and cache snapshots. - Update nested post/admin URLs, notifications, activity, copy links, and system specs to canonical `/t/...` browser URLs. - Split scroll-anchor persistence from full nested model cache snapshots to avoid expensive cache writes on scroll. - Add bounded scroll restoration retries for mobile browser-back focus restoration.
84 lines
3.3 KiB
Ruby
Vendored
84 lines
3.3 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Nested view collapse_replies URL param" do
|
|
fab!(:op_user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:replier_a) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:replier_b) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:replier_c) { Fabricate(:user, refresh_auto_groups: true) }
|
|
|
|
fab!(:topic) { Fabricate(:topic, user: op_user) }
|
|
fab!(:op_post) { Fabricate(:post, topic: topic, user: op_user, post_number: 1) }
|
|
fab!(:root_post) do
|
|
Fabricate(:post, topic: topic, user: replier_a, post_number: 2, reply_to_post_number: nil)
|
|
end
|
|
fab!(:reply_to_root) do
|
|
Fabricate(:post, topic: topic, user: replier_b, post_number: 3, reply_to_post_number: 2)
|
|
end
|
|
fab!(:reply_to_reply) do
|
|
Fabricate(:post, topic: topic, user: replier_c, post_number: 4, reply_to_post_number: 3)
|
|
end
|
|
|
|
let(:nested_view) { PageObjects::Pages::NestedView.new }
|
|
|
|
before do
|
|
SiteSetting.nested_replies_enabled = true
|
|
Fabricate(:nested_topic, topic: topic)
|
|
sign_in(op_user)
|
|
end
|
|
|
|
context "in the root view" do
|
|
it "renders all descendants by default" do
|
|
nested_view.visit_nested(topic)
|
|
|
|
expect(nested_view).to have_post(root_post)
|
|
expect(nested_view).to have_post(reply_to_root)
|
|
expect(nested_view).to have_post(reply_to_reply)
|
|
end
|
|
|
|
it "hides the root post's replies entirely when collapse_replies=true" do
|
|
page.visit("/t/#{topic.slug}/#{topic.id}?collapse_replies=true")
|
|
|
|
# Roots are the focal level — visible.
|
|
expect(nested_view).to have_post(root_post)
|
|
|
|
# Their replies (depth 1+) are hidden behind an "Expand X replies"
|
|
# button on the root, so the user can scan only the new roots.
|
|
expect(nested_view).to have_no_post(reply_to_root)
|
|
expect(nested_view).to have_no_post(reply_to_reply)
|
|
end
|
|
end
|
|
|
|
context "in the context view" do
|
|
it "renders direct replies but hides grandchildren when collapse_replies=true" do
|
|
page.visit("/t/#{topic.slug}/#{topic.id}/#{root_post.post_number}?collapse_replies=true")
|
|
|
|
expect(nested_view).to have_context_view
|
|
|
|
# Chain root and its direct replies (the "new content") are visible.
|
|
expect(nested_view).to have_post(root_post)
|
|
expect(nested_view).to have_post(reply_to_root)
|
|
|
|
# Grandchildren of the chain root are collapsed behind an "Expand"
|
|
# button on the depth-1 reply.
|
|
expect(nested_view).to have_no_post(reply_to_reply)
|
|
end
|
|
|
|
# collapse_replies is a "consolidated bucket parent" affordance: it
|
|
# makes sense when the chain root IS the target (hide bucketed
|
|
# replies behind a button). When the target is *below* the chain
|
|
# root, applying collapseFromDepth=1 would hide the target itself,
|
|
# defeating the whole point of the context view. The
|
|
# collapseFromDepth getter in nested.gjs ignores
|
|
# collapse_replies in that case.
|
|
it "ignores collapse_replies and shows the target when the chain has ancestors" do
|
|
page.visit("/t/#{topic.slug}/#{topic.id}/#{reply_to_reply.post_number}?collapse_replies=true")
|
|
|
|
expect(nested_view).to have_context_view
|
|
|
|
# Full chain renders: root → reply_to_root → reply_to_reply (target).
|
|
expect(nested_view).to have_post(root_post)
|
|
expect(nested_view).to have_post(reply_to_root)
|
|
expect(nested_view).to have_post(reply_to_reply)
|
|
end
|
|
end
|
|
end
|
