mirror of
https://github.com/discourse/discourse.git
synced 2026-03-03 23:54:20 +08:00
d69cc29979
### What is this change? Some time back we went through an exercise to turn trust-level based access to group-level based for better configurability. This involved deprecating, mapping, and replacing site settings. We marked the old settings for removal in 3.3, which was released over a year ago now. This PR removes the deprecated settings, their descriptions, the mapping helpers, and updates a few test cases we missed in the original conversion. ### Due diligence: - [x] Search through logs for recent deprecation warnings. (@Drenmi) - There are some false positives due to `UserMerger` looping through all site settings (including deprecated ones.) - [ ] Search through public and private repos for latent references. (@Drenmi) --------- Co-authored-by: Martin Brennan <martin@discourse.org>
53 lines
1.8 KiB
Ruby
53 lines
1.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Admin Site Setting Search", type: :system do
|
|
let(:settings_page) { PageObjects::Pages::AdminSiteSettings.new }
|
|
fab!(:admin)
|
|
|
|
before do
|
|
SiteSetting.title = "Discourse"
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "clears the filter" do
|
|
settings_page.visit
|
|
settings_page.type_in_search("min personal message post length")
|
|
expect(settings_page).to have_n_results(1)
|
|
settings_page.clear_search
|
|
expect(settings_page).to have_greater_than_n_results(1)
|
|
end
|
|
|
|
it "can show only overridden settings" do
|
|
overridden_setting_count = SiteSetting.all_settings(only_overridden: true).length
|
|
settings_page.visit
|
|
settings_page.toggle_only_show_overridden
|
|
assert_selector(".admin-detail .row.setting.overridden", count: overridden_setting_count)
|
|
settings_page.toggle_only_show_overridden
|
|
expect(settings_page).to have_greater_than_n_results(overridden_setting_count)
|
|
end
|
|
|
|
describe "when searching for keywords" do
|
|
it "finds the replacement site setting when deprecated" do
|
|
stub_deprecated_settings!(override: false) do
|
|
settings_page.visit
|
|
settings_page.type_in_search("old_one")
|
|
expect(settings_page).to have_search_result("new_one")
|
|
end
|
|
end
|
|
|
|
it "finds the associated site setting when many keywords" do
|
|
settings_page.visit
|
|
settings_page.type_in_search("deactivated")
|
|
expect(settings_page).to have_search_result("clean_up_inactive_users_after_days")
|
|
expect(settings_page).to have_search_result("purge_unactivated_users_grace_period_days")
|
|
end
|
|
|
|
it "can search for previous site setting without underscores" do
|
|
stub_deprecated_settings!(override: false) do
|
|
settings_page.visit
|
|
settings_page.type_in_search("old one")
|
|
expect(settings_page).to have_search_result("new_one")
|
|
end
|
|
end
|
|
end
|
|
end
|
