2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-03-04 01:15:08 +08:00
discourse/spec/requests/badges_controller_spec.rb
Sam bb4b5ecdb9
FIX: Non-listable and disabled badges exposed via XHR JSON requests (#37869)
Non-listable and disabled badges exposed to anonymous users via XHR JSON
requests to `GET /badges.json`.

This is minor badges are not a security feature, but this is nice
defense in depth
2026-02-17 16:17:01 +11:00

170 lines
5.4 KiB
Ruby

# frozen_string_literal: true
RSpec.describe BadgesController do
fab!(:badge)
fab!(:user)
before { SiteSetting.enable_badges = true }
describe "#index" do
it "should return a list of all badges" do
get "/badges.json"
expect(response.status).to eq(200)
parsed = response.parsed_body
expect(parsed["badges"].length).to eq(Badge.enabled.count)
expect(response.headers["X-Robots-Tag"]).to eq("noindex")
end
it "does not expose disabled badges via XHR requests" do
disabled_badge = Fabricate(:badge, enabled: false)
get "/badges.json", headers: { "HTTP_X_REQUESTED_WITH" => "XMLHttpRequest" }
expect(response.status).to eq(200)
badge_ids = response.parsed_body["badges"].map { |b| b["id"] }
expect(badge_ids).not_to include(disabled_badge.id)
end
it "does not expose non-listable badges via XHR requests" do
non_listable_badge = Fabricate(:badge, listable: false)
get "/badges.json", headers: { "HTTP_X_REQUESTED_WITH" => "XMLHttpRequest" }
expect(response.status).to eq(200)
badge_ids = response.parsed_body["badges"].map { |b| b["id"] }
expect(badge_ids).not_to include(non_listable_badge.id)
end
it "allows staff to see disabled and non-listable badges via XHR requests" do
admin = Fabricate(:admin)
disabled_badge = Fabricate(:badge, enabled: false)
non_listable_badge = Fabricate(:badge, listable: false)
sign_in(admin)
get "/badges.json", headers: { "HTTP_X_REQUESTED_WITH" => "XMLHttpRequest" }
expect(response.status).to eq(200)
badge_ids = response.parsed_body["badges"].map { |b| b["id"] }
expect(badge_ids).to include(disabled_badge.id)
expect(badge_ids).to include(non_listable_badge.id)
end
it "filters disabled and non-listable badges for staff on non-XHR requests" do
admin = Fabricate(:admin)
disabled_badge = Fabricate(:badge, enabled: false)
non_listable_badge = Fabricate(:badge, listable: false)
sign_in(admin)
get "/badges.json"
expect(response.status).to eq(200)
badge_ids = response.parsed_body["badges"].map { |b| b["id"] }
expect(badge_ids).not_to include(disabled_badge.id)
expect(badge_ids).not_to include(non_listable_badge.id)
end
it "filters disabled and non-listable badges for staff when only_listable param is true" do
admin = Fabricate(:admin)
disabled_badge = Fabricate(:badge, enabled: false)
non_listable_badge = Fabricate(:badge, listable: false)
sign_in(admin)
get "/badges.json",
params: {
only_listable: "true",
},
headers: {
"HTTP_X_REQUESTED_WITH" => "XMLHttpRequest",
}
expect(response.status).to eq(200)
badge_ids = response.parsed_body["badges"].map { |b| b["id"] }
expect(badge_ids).not_to include(disabled_badge.id)
expect(badge_ids).not_to include(non_listable_badge.id)
end
end
describe "#show" do
it "should return a badge" do
get "/badges/#{badge.id}.json"
expect(response.status).to eq(200)
parsed = response.parsed_body
expect(parsed["badge"]).to be_present
end
it "should mark the notification as viewed" do
sign_in(user)
user_badge = BadgeGranter.grant(badge, user)
expect(user_badge.notification.read).to eq(false)
get "/badges/#{badge.id}.json"
expect(user_badge.notification.reload.read).to eq(true)
end
it "renders rss feed of a badge" do
get "/badges/#{badge.id}.rss"
expect(response.status).to eq(200)
expect(response.media_type).to eq("application/rss+xml")
end
end
describe "user profiles" do
let(:titled_badge) { Fabricate(:badge, name: "Protector of the Realm", allow_title: true) }
let!(:grant) do
UserBadge.create!(
user_id: user.id,
badge_id: titled_badge.id,
granted_at: 1.minute.ago,
granted_by_id: -1,
)
end
it "can be assigned as a title by the user" do
sign_in(user)
put "/u/#{user.username}/preferences/badge_title.json", params: { user_badge_id: grant.id }
expect(response.status).to eq(200)
user.reload
expect(user.title).to eq(titled_badge.display_name)
expect(user.user_profile.granted_title_badge_id).to eq(titled_badge.id)
end
end
describe "destroy" do
let(:admin) { Fabricate(:admin) }
context "while assigned as a title" do
let(:titled_badge) { Fabricate(:badge, name: "Protector of the Realm", allow_title: true) }
let!(:grant) do
UserBadge.create!(
user_id: user.id,
badge_id: titled_badge.id,
granted_at: 1.minute.ago,
granted_by_id: -1,
)
end
before do
sign_in(user)
put "/u/#{user.username}/preferences/badge_title.json", params: { user_badge_id: grant.id }
user.reload
sign_out
end
it "succeeds and unassigns the title from the user" do
expect(user.title).to eq(titled_badge.display_name)
sign_in(admin)
badge_id = titled_badge.id
delete "/admin/badges/#{titled_badge.id}.json"
expect(response.status).to be(200)
expect(Badge.find_by(id: badge_id)).to be(nil)
user.reload
expect(user.title).to_not eq(titled_badge.display_name)
expect(user.user_profile.granted_title_badge_id).to eq(nil)
end
end
end
end