mirror of
https://github.com/discourse/discourse.git
synced 2026-03-04 01:15:08 +08:00
71b96243e1
There exists a `localization_guardian` that checks if a user can localize based on settings like - `content_localization_allowed_groups` - `content_localization_allow_author_localization` However, it missed out checking if the user can even see the model. This commit fixes that by adding the checks. This issue was found as I was adding a new model (`tags`) and discovered they were absent for the older models. This commit also introduces a small refactor that `.find`s the model first on the controller and passes the object, so that the subsequent services do not have to `.find` them again.
59 lines
1.6 KiB
Ruby
59 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe PostLocalizationCreator do
|
|
fab!(:user)
|
|
fab!(:post)
|
|
fab!(:group)
|
|
|
|
let(:locale) { "ja" }
|
|
let(:raw) { "これは翻訳です。" }
|
|
|
|
before do
|
|
SiteSetting.content_localization_enabled = true
|
|
SiteSetting.content_localization_allowed_groups = group.id.to_s
|
|
group.add(user)
|
|
end
|
|
|
|
it "creates a post localization record" do
|
|
localization = described_class.create(post:, locale:, raw:, user:)
|
|
|
|
expect(PostLocalization.find(localization.id)).to have_attributes(
|
|
post_id: post.id,
|
|
locale:,
|
|
raw:,
|
|
localizer_user_id: user.id,
|
|
cooked: PrettyText.cook(raw),
|
|
)
|
|
end
|
|
|
|
it "enqueues ProcessLocalizedCook job" do
|
|
loc = described_class.create(post:, locale:, raw:, user:)
|
|
|
|
expect_job_enqueued(job: :process_localized_cooked, args: { post_localization_id: loc.id })
|
|
end
|
|
|
|
context "with author localization" do
|
|
fab!(:author, :user)
|
|
fab!(:author_post) { Fabricate(:post, user: author) }
|
|
fab!(:other_post, :post)
|
|
|
|
before { SiteSetting.content_localization_allow_author_localization = true }
|
|
|
|
it "allows post author to create localization for their own post" do
|
|
localization = described_class.create(post: author_post, locale:, raw:, user: author)
|
|
|
|
expect(localization).to have_attributes(
|
|
post_id: author_post.id,
|
|
locale:,
|
|
raw:,
|
|
localizer_user_id: author.id,
|
|
)
|
|
end
|
|
|
|
it "raises permission error if user is not the post author" do
|
|
expect {
|
|
described_class.create(post: other_post, locale:, raw:, user: author)
|
|
}.to raise_error(Discourse::InvalidAccess)
|
|
end
|
|
end
|
|
end
|
