mirror of
https://github.com/discourse/discourse.git
synced 2026-03-03 23:54:20 +08:00
8b789c9306
## 🔍 Overview This update allows for having uploads on localized posts. If no uploads are made, translated posts will show the original uploaded image. However, if a translator would like to upload a translated image, the composer will now support an upload reference. ## 🔗 Relevant Links As requested on Meta: https://meta.discourse.org/t/translation-composer-missing-image-upload-support/386829 ## 📹 Screen Recordings https://github.com/user-attachments/assets/f01fdfde-c84b-46d8-a96d-a4641699b3b9
96 lines
2.8 KiB
Ruby
96 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe LocalizedCookedPostProcessor do
|
|
fab!(:post)
|
|
fab!(:upload1, :upload)
|
|
fab!(:upload2, :upload)
|
|
|
|
let(:image_url) { upload1.short_url }
|
|
let(:image_url_2) { upload2.short_url }
|
|
|
|
let(:raw_with_uploads) { <<~RAW }
|
|
これは翻訳されたコンテンツです。
|
|
|
|
|
|
RAW
|
|
|
|
let(:cooked_with_uploads) { PrettyText.cook(raw_with_uploads) }
|
|
|
|
let(:localization) do
|
|
Fabricate(:post_localization, post: post, raw: raw_with_uploads, cooked: cooked_with_uploads)
|
|
end
|
|
|
|
let(:processor) { LocalizedCookedPostProcessor.new(localization, post) }
|
|
|
|
describe "#post_process" do
|
|
it "calls link_post_uploads on the localization" do
|
|
localization.expects(:link_post_uploads).with(
|
|
fragments: processor.instance_variable_get(:@doc),
|
|
)
|
|
processor.post_process
|
|
end
|
|
|
|
it "creates upload references for uploads in the localization" do
|
|
processor.post_process
|
|
|
|
upload_ids = UploadReference.where(target: localization).pluck(:upload_id)
|
|
expect(upload_ids).to contain_exactly(upload1.id, upload2.id)
|
|
end
|
|
|
|
it "uses PostLocalization as the target type for upload references" do
|
|
processor.post_process
|
|
|
|
upload_ref = UploadReference.find_by(target: localization, upload_id: upload1.id)
|
|
expect(upload_ref.target_type).to eq("PostLocalization")
|
|
expect(upload_ref.target_id).to eq(localization.id)
|
|
end
|
|
|
|
context "when the localization already has upload references" do
|
|
before do
|
|
UploadReference.create!(
|
|
target: localization,
|
|
upload: upload1,
|
|
created_at: Time.zone.now,
|
|
updated_at: Time.zone.now,
|
|
)
|
|
end
|
|
|
|
it "replaces the old upload references" do
|
|
old_ref_id = localization.upload_references.first.id
|
|
|
|
processor.post_process
|
|
|
|
expect(UploadReference.exists?(old_ref_id)).to eq(false)
|
|
expect(localization.reload.upload_references.pluck(:upload_id)).to contain_exactly(
|
|
upload1.id,
|
|
upload2.id,
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when secure uploads is enabled" do
|
|
before do
|
|
setup_s3
|
|
SiteSetting.authorized_extensions = "pdf|png|jpg|csv"
|
|
SiteSetting.secure_uploads = true
|
|
end
|
|
|
|
it "sets access_control_post_id to the parent post" do
|
|
processor.post_process
|
|
|
|
upload1.reload
|
|
expect(upload1.access_control_post_id).to eq(post.id)
|
|
end
|
|
|
|
it "does not override existing access_control_post_id" do
|
|
other_post = Fabricate(:post)
|
|
upload1.update!(access_control_post_id: other_post.id)
|
|
|
|
processor.post_process
|
|
|
|
upload1.reload
|
|
expect(upload1.access_control_post_id).to eq(other_post.id)
|
|
end
|
|
end
|
|
end
|
|
end
|
