mirror of
https://github.com/discourse/discourse.git
synced 2026-03-05 15:27:34 +08:00
63ca5673df
What is the problem? `TopicLink` records can reference deleted topics or posts. When a topic or the target post being linked to is deleted, these orphaned links continue to appear in topic maps and post link counts. Note that `TopicLink` records are already deleted when the source post containing the link is trashed (see `Post#trash!`), so we only need to filter for deleted target topics/posts. Additionally, internal links stored with http:// are not normalized to https:// when `force_https` site setting is enabled. --- What is the solution? Extend filtering in `TopicLink.topic_map` and `TopicLink.counts_for` to exclude links where the target topic or target post is deleted. Extract common visibility filters into `TopicLink.apply_link_visibility_filters` helper method. Normalize internal http:// URLs to https:// in `TopicLinkSerializer#url` when `force_https` is enabled.
6 lines
108 B
Ruby
6 lines
108 B
Ruby
# frozen_string_literal: true
|
|
|
|
Fabricator(:topic_link_click) do
|
|
topic_link
|
|
ip_address "192.168.1.1"
|
|
end
|
