mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 02:59:07 +08:00
837bd271fdSubscriptions rendered its own nav inside the page (legacy) and hid it entirely until Stripe was configured, so from the sidebar, a fresh install landed on a dead-end "Stripe is not configured" message. This change moves the plugin onto the newer admin show route, and an unconfigured Stripe lands on the settings tab with the other tabs showing an empty state that links back to settings. Also removed some dead code Before: <img width="2762" height="818" alt="image" src="https://github.com/user-attachments/assets/0896d0eb-f183-4e29-a724-07f6cc0ef847" /> After: <img width="2272" height="1244" alt="image" src="https://github.com/user-attachments/assets/607d396f-3beb-4275-967e-c1d6f3169955" /> --------- Co-authored-by: Martin Brennan <martin@discourse.org>
75 lines
2.7 KiB
Ruby
Vendored
75 lines
2.7 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe "Configure subscriptions plugin", allow_network: ["js.stripe.com"] do
|
|
fab!(:admin)
|
|
|
|
let(:config_page) { PageObjects::Pages::AdminSubscriptionsConfig.new }
|
|
let(:sidebar) { PageObjects::Components::NavigationMenu::Sidebar.new }
|
|
|
|
before do
|
|
SiteSetting.discourse_subscriptions_enabled = true
|
|
SiteSetting.navigation_menu = "sidebar"
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "takes the admin to the products tab, alongside the other tabs, once Stripe keys are set" do
|
|
SiteSetting.discourse_subscriptions_secret_key = "sk_test_51xuu"
|
|
SiteSetting.discourse_subscriptions_public_key = "pk_test_51xuu"
|
|
::Stripe::Product.stubs(:list).returns({ data: [] })
|
|
|
|
config_page.visit
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/products")
|
|
expect(config_page).to have_tabs("Settings", "Products", "Coupons", "Subscriptions")
|
|
end
|
|
|
|
it "takes the admin to the settings tab when Stripe has not been set up yet" do
|
|
config_page.visit
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/settings")
|
|
expect(config_page).to have_tabs("Settings", "Products", "Coupons", "Subscriptions")
|
|
end
|
|
|
|
it "takes the admin to the settings tab when only the publishable key is set" do
|
|
SiteSetting.discourse_subscriptions_public_key = "pk_test_51xuu"
|
|
|
|
config_page.visit
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/settings")
|
|
end
|
|
|
|
it "takes the admin to the settings tab when only the secret key is set" do
|
|
SiteSetting.discourse_subscriptions_secret_key = "sk_test_51xuu"
|
|
|
|
config_page.visit
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/settings")
|
|
end
|
|
|
|
it "tells the admin why the products tab is empty rather than sending them back to settings" do
|
|
config_page.visit
|
|
config_page.click_tab("Products")
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/products")
|
|
expect(config_page).to have_stripe_unconfigured_notice
|
|
end
|
|
|
|
it "tells the admin why the products tab is empty when only the publishable key is set" do
|
|
SiteSetting.discourse_subscriptions_public_key = "pk_test_51xuu"
|
|
|
|
config_page.visit
|
|
config_page.click_tab("Products")
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/products")
|
|
expect(config_page).to have_stripe_unconfigured_notice
|
|
end
|
|
|
|
it "takes the admin to the settings tab when arriving from another plugin's page" do
|
|
visit("/admin/plugins/poll/settings")
|
|
|
|
sidebar.click_section_header("admin-plugins")
|
|
sidebar.click_link_in_section("admin-plugins", "admin_plugin_discourse-subscriptions")
|
|
|
|
expect(page).to have_current_path("/admin/plugins/discourse-subscriptions/settings")
|
|
end
|
|
end
|
