Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-04-29 15:45:23 +08:00
Code Packages Activity Actions
discourse/plugins/discourse-post-voting/spec
History
Exact
chapoi 8e44060201
UX: post voting styling, accessibility, and small fixes (#39443) 
This PR started mainly to apply styling changes to remain consistent
with its sister TopicVoting plugin: #39234

Inevitably, this also lead to some refactoring as there was still a lot
legacy in use in this plugin.
In this commit:
- Rewrote styles using BEM conventions, trimming down from 9 > 4
BlockElements, and spacing variables
- Consolidated `common`/`mobile`/`desktop` stylesheets into a single
responsive sheet using `viewport` mixins
- Replaced the custom comments popup with `DMenu`
  - Swapped `angle-up` icons for `vote-up` / `vote-up-filled`
- Updated sort controls to match standard navigation styling pills and
to refresh in place
  - Updated character counter for composer to use standard counter
  - Added a zero-upvotes, to maintain alignment in comments  
- Refined styling for sizing, font-colours, spacing,…
  - Cleaned up class names and wrapper markup
- Fixed missing accessibility by adding aria-labels, titles, and
translation strings for vote buttons, comment actions, and the "show who
voted" toggle

Note: Nothing in the all-the-themes repo customises this, except for one
third-party, which has been notified of the refactor. Unity needs some
class changes (done
[here](https://github.com/discourse/discourse-unity-theme/pull/83)) .


### Desktop
| BC | AC |
|--------|--------|
| <img width="1348" height="1624" alt="CleanShot 2026-04-22 at 11 44
21@2x"
src="https://github.com/user-attachments/assets/608c1e37-72a9-461a-b873-cb494c491a8e"
/> | <img width="1438" height="1614" alt="CleanShot 2026-04-22 at 11 40
39@2x"
src="https://github.com/user-attachments/assets/9b3437c8-c2ad-47cb-a06a-fd259e461455"
/> |
| <img width="1348" height="1624" alt="CleanShot 2026-04-22 at 11 45
27@2x"
src="https://github.com/user-attachments/assets/499cf9f4-4b89-433a-b5ff-517a651b945f"
/> | <img width="1438" height="1610" alt="CleanShot 2026-04-22 at 11 41
30@2x"
src="https://github.com/user-attachments/assets/99e98fa3-0372-4b1b-ba66-5d8b188559b6"
/> |



### Mobile
| BC | AC |
|--------|--------|
| <img width="1179" height="2556" alt="image"
src="https://github.com/user-attachments/assets/94cc8e9c-06c2-42bd-9fca-b8605557452b"
/> | <img width="1179" height="2556" alt="image"
src="https://github.com/user-attachments/assets/5f2d3b65-7c78-422d-b603-a9b1d498c619"
/> |
2026-04-22 14:41:12 +02:00
..
components/post_voting DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073) 2025-10-06 16:11:01 +02:00
fabricators FEATURE: Update the ReviewablePostVotingComment UI (#35675) 2025-10-31 11:50:14 +08:00
lib DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073) 2025-10-06 16:11:01 +02:00
models DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073) 2025-10-06 16:11:01 +02:00
requests UX: post voting styling, accessibility, and small fixes (#39443) 2026-04-22 14:41:12 +02:00
serializers DEV: Don't use fab! for non-ActiveRecord model objects (#39272) 2026-04-15 00:52:34 +02:00
system UX: post voting styling, accessibility, and small fixes (#39443) 2026-04-22 14:41:12 +02:00
plugin_helper.rb