mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-06-19 06:43:54 +08:00
d62cc48d9c
Replaces the custom ~1000-line `to-markdown` converter with ProseMirror's schema-based parsing and serialization pipeline, reusing the same extensions that power the rich editor. The old converter duplicated logic the extensions already implement (image formatting, mention/hashtag serialization, table handling, list nesting, etc.) — a single pipeline means one set of rules, fewer divergence bugs, and plugin extensions work in both directions automatically. ### Core change - `toMarkdown()` is now async and lazy-loads ProseMirror on first use. - Cooked→markdown serialization runs through the registered rich-editor extensions, so both conversion directions share one source of truth. ### QuoteState and quote callers Making `toMarkdown()` async changed the quote flow. `QuoteState` now stores the selection's HTML and exposes an async `markdown()`; `buffer` is the plain-text selection. Every caller that needs markdown was updated to await `markdown()`: - Topic controller (`selectText`, `replyToPost` including EmbedMode, `replyAsNewTopic`, `buildQuoteMarkdown`). - Nested controller — forwards the full selection state via the new `copyFrom`. - Fast-edit modal and `computeSupportsFastEdit`. - discourse-ai post-helper menu — now sends markdown (not plain text) to the AI endpoints. `markdown()` snapshots `opts` before awaiting so a concurrent selection change can't mis-pair the result. ### Plugin API - Removed plugin-specific `addTagDecorateCallback`/`addTextDecorateCallback` usage from local-dates and spoiler-alert (the old APIs are kept as deprecated no-ops). local-dates now uses a `transformParsedHTML` rich-editor extension hook. ### Extractions and sharing - Word paste handling moved into a dedicated `word-paste.js` extension. - Quote-selection list-structure preservation moved into `preserve-list-structure.js`. - `normalizeTable` is shared between the paste plugin and the serializer for consistent table output across editor modes. ### Quoting fix - `selectedHTML` drops the empty trailing block a triple-click leaves behind. A triple-click extends the selection's end to the start of the following block, so `cloneContents()` would otherwise clone an empty `<blockquote>` that serializes to a stray `> ` in the quote.
44 lines
1.6 KiB
JavaScript
Vendored
44 lines
1.6 KiB
JavaScript
Vendored
import { setupTest } from "ember-qunit";
|
|
import { module, test } from "qunit";
|
|
import {
|
|
getExtensions,
|
|
registerRichEditorExtension,
|
|
resetRichEditorExtensions,
|
|
} from "discourse/lib/composer/rich-editor-extensions";
|
|
import toMarkdown from "discourse/lib/to-markdown";
|
|
import mathExtension from "discourse/plugins/discourse-math/lib/rich-editor-extension";
|
|
|
|
module("Unit | Lib | to-markdown-math", function (hooks) {
|
|
setupTest(hooks);
|
|
|
|
hooks.beforeEach(async function () {
|
|
await resetRichEditorExtensions();
|
|
if (!getExtensions().includes(mathExtension)) {
|
|
registerRichEditorExtension(mathExtension);
|
|
}
|
|
});
|
|
|
|
test("converts inline mathjax to markdown", async function (assert) {
|
|
const html = `<p>Lorem ipsum <span class="math" data-applied-mathjax="true" style="display: none;">E=mc^2</span><span class="math-container inline-math mathjax-math" style=""><mjx-container class="MathJax" jax="SVG"><svg></svg></mjx-container></span> dolor sit amet.</p>`;
|
|
const markdown = `Lorem ipsum $E=mc^2$ dolor sit amet.`;
|
|
assert.strictEqual(await toMarkdown(html), markdown);
|
|
});
|
|
|
|
test("converts block mathjax to markdown", async function (assert) {
|
|
const html = `<p>Before</p>
|
|
<div class="math" data-applied-mathjax="true" style="display: none;">
|
|
\\sqrt{(-1)} \\; 2^3 \\; \\sum \\; \\pi
|
|
</div><div class="math-container block-math mathjax-math" style=""><mjx-container class="MathJax" jax="SVG" display="true"><svg></svg></mjx-container></div>
|
|
<p>After</p>`;
|
|
|
|
const markdown = `Before
|
|
|
|
$$
|
|
\\sqrt{(-1)} \\; 2^3 \\; \\sum \\; \\pi
|
|
$$
|
|
|
|
After`;
|
|
|
|
assert.strictEqual(await toMarkdown(html), markdown);
|
|
});
|
|
});
|
