mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-04-30 09:09:18 +08:00
a9b1fb9b43
Some checks are pending
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Publish Assets / publish-assets (push) Waiting to run
Tests / core backend (push) Waiting to run
Tests / plugins backend (push) Waiting to run
Tests / core frontend (Chrome) (push) Waiting to run
Tests / plugins frontend (push) Waiting to run
Tests / themes frontend (push) Waiting to run
Tests / core system (push) Waiting to run
Tests / plugins system (push) Waiting to run
Tests / themes system (push) Waiting to run
Tests / core frontend (Firefox ESR) (push) Waiting to run
Tests / core frontend (Firefox Evergreen) (push) Waiting to run
Tests / chat system (push) Waiting to run
Tests / merge (push) Blocked by required conditions
Lazily loaded videos currently won't be picked up by search engines as they do not contain an iframe or VideoObject. This commit uses a new API `build_plugin_html "server:topic-show-crawler-post-end"` to insert populated [ld+json](https://developers.google.com/search/docs/appearance/structured-data/intro-structured-data#supported-formats) into the end of each post which has a video. Results: - https://search.google.com/test/rich-results/result?id=vegb8Qkz7HThsMbFaeN2AQ - https://search.google.com/test/rich-results/result?id=asumX41RneM2tMstchv45A - (vimeo) https://search.google.com/test/rich-results/result?id=EZWOMJCkDqEQIHfOLkSkcw Note: There were originally two ways around this - add each VideoObject to the `post.cook` all the time agnostic of crawler view - or add them to the `<head>` with appropriate metadata, needing to duplicate all post meta data within a `isPartOf` attribute. I chose to create a new api so that we can satisfy both "only add the meta data in crawler view" and prevent post metadata duplication.
46 lines
1.4 KiB
Ruby
46 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "onebox"
|
|
|
|
class Onebox::Engine::YoutubeOnebox
|
|
include Onebox::Engine
|
|
alias_method :default_onebox_to_html, :to_html
|
|
|
|
def to_html
|
|
if SiteSetting.lazy_videos_enabled && SiteSetting.lazy_youtube_enabled && video_id &&
|
|
!params["list"]
|
|
result = parse_embed_response
|
|
result ||= get_opengraph.data
|
|
|
|
thumbnail_url = "https://img.youtube.com/vi/#{video_id}/maxresdefault.jpg"
|
|
|
|
begin
|
|
Onebox::Helpers.fetch_response(thumbnail_url)
|
|
rescue StandardError
|
|
thumbnail_url = result[:image]
|
|
end
|
|
|
|
return default_onebox_to_html if video_title.chomp("- YouTube").blank? || thumbnail_url.blank?
|
|
|
|
escaped_title = ERB::Util.html_escape(video_title)
|
|
escaped_start_time = ERB::Util.html_escape(params["t"])
|
|
t_param = "&t=#{escaped_start_time}" if escaped_start_time.present?
|
|
|
|
<<~HTML
|
|
<div class="youtube-onebox lazy-video-container"
|
|
data-video-id="#{video_id}"
|
|
data-video-title="#{escaped_title}"
|
|
data-video-start-time="#{escaped_start_time}"
|
|
data-provider-name="youtube">
|
|
<a href="https://www.youtube.com/watch?v=#{video_id}#{t_param}" target="_blank" class="video-thumbnail">
|
|
<img class="youtube-thumbnail"
|
|
src="#{thumbnail_url}"
|
|
title="#{escaped_title}">
|
|
</a>
|
|
</div>
|
|
HTML
|
|
else
|
|
default_onebox_to_html
|
|
end
|
|
end
|
|
end
|
