mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-06-19 04:03:45 +08:00
848c19ae48
## Summary - Moves scorable weight configuration and category filtering from global site settings to individual leaderboards - Each leaderboard can override any of the 15 score weight values and specify its own scorable categories - Score calculation now runs per leaderboard into a new `gamification_leaderboard_scores` table - Admin UI gains a "Scoring configuration" section on the leaderboard edit form ## Details Previously all leaderboards shared the same pre-calculated scores from global site settings. This made it impossible to have e.g. a "posts-only" leaderboard alongside a "likes-focused" one. Now each leaderboard can optionally override: - **Score weights**: Set per-action point values (empty = inherit global default, 0 = disabled) - **Scorable categories**: Restrict which categories count toward scoring (empty = inherit global setting) The old `gamification_scores` table is no longer written to — a post-deploy migration to drop it will follow separately. ## Test plan - [ ] Create a leaderboard with default scoring — scores match current behavior - [ ] Create a leaderboard with custom weights (e.g. `post_created` = 10, all others empty) — only overridden weights differ - [ ] Set a weight to 0 — that scorable is disabled for the leaderboard - [ ] Set per-leaderboard categories — only those categories count - [ ] Clear categories — inherits global `scorable_categories` setting - [ ] Existing leaderboards with no overrides behave identically after upgrade - [ ] Directory scores and user card scores work correctly (read from default leaderboard) - [ ] `bin/rspec plugins/discourse-gamification/spec/` — 120 examples, 0 failures
41 lines
1.3 KiB
Ruby
Vendored
41 lines
1.3 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe Jobs::UpdateStaleLeaderboardPositions do
|
|
fab!(:leaderboard, :gamification_leaderboard)
|
|
fab!(:score) do
|
|
Fabricate(
|
|
:gamification_leaderboard_score,
|
|
leaderboard_id: leaderboard.id,
|
|
user_id: leaderboard.created_by_id,
|
|
)
|
|
end
|
|
let(:leaderboard_positions) { DiscourseGamification::LeaderboardCachedView.new(leaderboard) }
|
|
|
|
it "it updates all stale leaderboard positions" do
|
|
DiscourseGamification::LeaderboardCachedView.new(leaderboard).create
|
|
|
|
expect(leaderboard_positions.scores.length).to eq(1)
|
|
expect(leaderboard_positions.scores.first.attributes).to include(
|
|
"id" => leaderboard.created_by_id,
|
|
"total_score" => 0,
|
|
"position" => 1,
|
|
)
|
|
|
|
allow_any_instance_of(DiscourseGamification::LeaderboardCachedView).to receive(
|
|
:total_scores_query,
|
|
).and_wrap_original do |original_method, period|
|
|
"#{original_method.call(period)} \n-- This is a new comment"
|
|
end
|
|
|
|
expect(leaderboard_positions.stale?).to eq(true)
|
|
|
|
described_class.new.execute
|
|
|
|
expect(leaderboard_positions.stale?).to eq(false)
|
|
expect(leaderboard_positions.scores.length).to eq(1)
|
|
expect(leaderboard_positions.scores.first.attributes).to include(
|
|
"id" => leaderboard.created_by_id,
|
|
"total_score" => 0,
|
|
)
|
|
end
|
|
end
|
