mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-06-19 04:03:45 +08:00
848c19ae48
## Summary - Moves scorable weight configuration and category filtering from global site settings to individual leaderboards - Each leaderboard can override any of the 15 score weight values and specify its own scorable categories - Score calculation now runs per leaderboard into a new `gamification_leaderboard_scores` table - Admin UI gains a "Scoring configuration" section on the leaderboard edit form ## Details Previously all leaderboards shared the same pre-calculated scores from global site settings. This made it impossible to have e.g. a "posts-only" leaderboard alongside a "likes-focused" one. Now each leaderboard can optionally override: - **Score weights**: Set per-action point values (empty = inherit global default, 0 = disabled) - **Scorable categories**: Restrict which categories count toward scoring (empty = inherit global setting) The old `gamification_scores` table is no longer written to — a post-deploy migration to drop it will follow separately. ## Test plan - [ ] Create a leaderboard with default scoring — scores match current behavior - [ ] Create a leaderboard with custom weights (e.g. `post_created` = 10, all others empty) — only overridden weights differ - [ ] Set a weight to 0 — that scorable is disabled for the leaderboard - [ ] Set per-leaderboard categories — only those categories count - [ ] Clear categories — inherits global `scorable_categories` setting - [ ] Existing leaderboards with no overrides behave identically after upgrade - [ ] Directory scores and user card scores work correctly (read from default leaderboard) - [ ] `bin/rspec plugins/discourse-gamification/spec/` — 120 examples, 0 failures
27 lines
885 B
Ruby
Vendored
27 lines
885 B
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe Jobs::GenerateLeaderboardPositions do
|
|
fab!(:user)
|
|
fab!(:leaderboard, :gamification_leaderboard)
|
|
fab!(:score) do
|
|
Fabricate(
|
|
:gamification_leaderboard_score,
|
|
leaderboard_id: leaderboard.id,
|
|
user_id: user.id,
|
|
score: 5,
|
|
)
|
|
end
|
|
let(:leaderboard_positions) { DiscourseGamification::LeaderboardCachedView.new(leaderboard) }
|
|
|
|
it "generates leaderboard positions from existing scores" do
|
|
expect { leaderboard_positions.scores }.to raise_error(
|
|
DiscourseGamification::LeaderboardCachedView::NotReadyError,
|
|
)
|
|
|
|
DiscourseGamification::GamificationLeaderboardScore.expects(:calculate_scores).never
|
|
described_class.new.execute(leaderboard_id: leaderboard.id)
|
|
|
|
expect(leaderboard_positions.scores.length).to eq(1)
|
|
expect(leaderboard_positions.scores.first.total_score).to eq(5)
|
|
end
|
|
end
|
