discourse/plugins/discourse-ai/spec/requests/ai_bot/artifacts_controller_spec.rb
Isaac Janzen 2b8c97a5f9
DEV: Harden AI artifact postMessage and COOP headers (#38647)
## Summary

- Forces `Cross-Origin-Opener-Policy: same-origin` on artifact `show`
pages, overriding the site-level COOP setting so the artifact page
always gets a dedicated browsing context
- Validates `event.source` against the child iframe in the KV
`postMessage` handler, rejecting messages from unrelated origins
2026-03-17 17:05:53 +11:00

164 lines
5.5 KiB
Ruby
Vendored

# frozen_string_literal: true
RSpec.describe DiscourseAi::AiBot::ArtifactsController do
fab!(:user)
fab!(:topic) { Fabricate(:private_message_topic, user: user) }
fab!(:post) { Fabricate(:post, user: user, topic: topic) }
fab!(:artifact) do
AiArtifact.create!(
user: user,
post: post,
name: "Test Artifact",
html: "<div>Hello World</div>",
css: "div { color: blue; }",
js: "console.log('test');",
metadata: {
public: false,
},
)
end
def parse_srcdoc(html)
Nokogiri.HTML5(html).at_css("iframe")["srcdoc"]
end
before do
enable_current_plugin
SiteSetting.ai_artifact_security = "strict"
end
describe "#show" do
it "returns 404 when discourse_ai is disabled" do
SiteSetting.discourse_ai_enabled = false
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(404)
end
it "returns 404 when ai_artifact_security disables it" do
SiteSetting.ai_artifact_security = "disabled"
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(404)
end
context "with private artifact" do
it "returns 404 when user cannot see the post" do
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(404)
end
it "shows artifact when user can see the post" do
sign_in(user)
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(200)
untrusted_html = parse_srcdoc(response.body)
expect(untrusted_html).to include(artifact.html)
expect(untrusted_html).to include(artifact.css)
expect(untrusted_html).to include(artifact.js)
end
it "can also find an artifact by its version" do
sign_in(user)
version = artifact.create_new_version(html: "<div>Was Updated</div>")
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}/#{version.version_number}"
expect(response.status).to eq(200)
untrusted_html = parse_srcdoc(response.body)
expect(untrusted_html).to include("Was Updated")
expect(untrusted_html).to include(artifact.css)
expect(untrusted_html).to include(artifact.js)
end
end
context "with non-PM artifact" do
fab!(:regular_topic) { Fabricate(:topic, user: user) }
fab!(:regular_post) { Fabricate(:post, user: user, topic: regular_topic) }
fab!(:regular_artifact) do
AiArtifact.create!(
user: user,
post: regular_post,
name: "Regular Topic Artifact",
html: "<div>Regular</div>",
css: "",
js: "",
metadata: {
public: false,
},
)
end
it "shows artifact to user who can see the post" do
sign_in(user)
get "/discourse-ai/ai-bot/artifacts/#{regular_artifact.id}"
expect(response.status).to eq(200)
expect(parse_srcdoc(response.body)).to include(regular_artifact.html)
end
it "returns 404 when user cannot see the post" do
other_user = Fabricate(:user)
regular_topic.update!(category: Fabricate(:private_category, group: Fabricate(:group)))
sign_in(other_user)
get "/discourse-ai/ai-bot/artifacts/#{regular_artifact.id}"
expect(response.status).to eq(404)
end
end
context "with public artifact" do
before { artifact.update!(metadata: { public: true }) }
it "shows artifact without authentication" do
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(200)
expect(parse_srcdoc(response.body)).to include(artifact.html)
end
end
it "sanitizes CSS to prevent style tag breakout" do
sign_in(user)
malicious_css = '</style><script>alert("XSS from CSS")</script><style>'
artifact.update!(css: malicious_css)
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(200)
untrusted_html = parse_srcdoc(response.body)
doc = Nokogiri.HTML5(untrusted_html)
script_contents = doc.css("script").map(&:text)
script_contents.each { |s| expect(s).not_to include("alert") }
style_tag = doc.at_css("style")
expect(style_tag.text).to include("alert")
end
it "removes security headers and disables crawling" do
sign_in(user)
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.headers["X-Frame-Options"]).to eq(nil)
expect(response.headers["Content-Security-Policy"]).to include("unsafe-inline")
expect(response.headers["X-Robots-Tag"]).to eq("noindex")
end
it "forces a same-origin opener policy for artifact pages" do
SiteSetting.cross_origin_opener_policy_header = "unsafe-none"
sign_in(user)
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(200)
expect(response.headers["Cross-Origin-Opener-Policy"]).to eq("same-origin")
end
it "validates event.source against the child iframe in the KV postMessage handler" do
sign_in(user)
get "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
expect(response.status).to eq(200)
doc = Nokogiri.HTML5(response.body)
parent_scripts = doc.css("body > script").map(&:text)
kv_handler_script = parent_scripts.find { |s| s.include?("discourse-artifact-kv") }
expect(kv_handler_script).to be_present
expect(kv_handler_script).to match(/event\.source\s*!==?\s*\w+\.contentWindow/)
end
end
end