mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
da11a72df0This allows links in pinned chat messages — now that these are more prominent they can be used to link to important information near the chat header. This also updates the use of pinned messages in livestream chat to utilize the links to refer to the livestream topic. The mechanism for hiding the first pin in the livestream topic docked chat needed to be updated. When viewing a livestream chat while not in the topic you see the topic reference pin: <img width="450" alt="image" src="https://github.com/user-attachments/assets/ed16b592-05a9-4450-95b0-0843a653e55b" /> This automatically pinned message is hidden when using the docked livestream chat, as you're already in the topic: <img width="1000" alt="image" src="https://github.com/user-attachments/assets/5c562154-b847-4d98-9075-afd563012673" />
767 lines
22 KiB
Text
Vendored
767 lines
22 KiB
Text
Vendored
import { tracked } from "@glimmer/tracking";
|
|
import { getOwner } from "@ember/owner";
|
|
import { click, render, settled } from "@ember/test-helpers";
|
|
import { module, test } from "qunit";
|
|
import KeyValueStore from "discourse/lib/key-value-store";
|
|
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import pretender, { response } from "discourse/tests/helpers/create-pretender";
|
|
import { publishToMessageBus } from "discourse/tests/helpers/qunit-helpers";
|
|
import ChatPinnedMessageBar from "discourse/plugins/chat/discourse/components/chat/pinned-message-bar";
|
|
import { STORE_NAMESPACE } from "discourse/plugins/chat/discourse/lib/chat-pinned-bar-dismissal";
|
|
import ChatFabricators from "discourse/plugins/chat/discourse/lib/fabricators";
|
|
|
|
function pinResponse(channel, count) {
|
|
const pinned_messages = [];
|
|
for (let i = 0; i < count; i++) {
|
|
// newest first (i=0), and message ids descend with i so the newest pin
|
|
// sits on the highest-id (bottom-most) message — matching the timeline
|
|
const messageId = 200 + (count - 1 - i);
|
|
pinned_messages.push({
|
|
id: 100 + i,
|
|
chat_message_id: messageId,
|
|
pinned_at: moment().subtract(i, "minute").toISOString(),
|
|
pinned_by: { id: 1, username: "alice" },
|
|
message: { id: messageId, excerpt: `Pinned excerpt ${i}`, message: "x" },
|
|
});
|
|
}
|
|
return response({ pinned_messages, membership: null });
|
|
}
|
|
|
|
// pins from the given ids (the bar orders by message id itself)
|
|
function pinsResponse(ids) {
|
|
return response({
|
|
pinned_messages: ids.map((id, i) => ({
|
|
id,
|
|
chat_message_id: 200 + id,
|
|
pinned_at: moment().subtract(i, "minute").toISOString(),
|
|
pinned_by: { id: 1, username: "alice" },
|
|
message: { id: 200 + id, excerpt: `Pin ${id}` },
|
|
})),
|
|
membership: null,
|
|
});
|
|
}
|
|
|
|
function excerptPinResponse(excerpt) {
|
|
return response({
|
|
pinned_messages: [
|
|
{
|
|
id: 100,
|
|
chat_message_id: 200,
|
|
pinned_at: moment().toISOString(),
|
|
pinned_by: { id: 1, username: "alice" },
|
|
excerpt,
|
|
message: { id: 200, excerpt: "Stripped excerpt", message: "x" },
|
|
},
|
|
],
|
|
membership: null,
|
|
});
|
|
}
|
|
|
|
// a single pin whose pin-record id is `pinId` (the value the bar compares
|
|
// against the dismissed-above id)
|
|
function dismissablePinResponse(pinId) {
|
|
return response({
|
|
pinned_messages: [
|
|
{
|
|
id: pinId,
|
|
chat_message_id: 200,
|
|
pinned_at: moment().toISOString(),
|
|
pinned_by: { id: 1, username: "alice" },
|
|
message: { id: 200, excerpt: "Pinned excerpt", message: "x" },
|
|
},
|
|
],
|
|
membership: null,
|
|
});
|
|
}
|
|
|
|
module("Component | ChatPinnedMessageBar", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
this.siteSettings.chat_pinned_messages = true;
|
|
this.channel = new ChatFabricators(getOwner(this)).channel();
|
|
this.noop = () => {};
|
|
});
|
|
|
|
test("does not render when the channel has no pins", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 0;
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").doesNotExist();
|
|
});
|
|
|
|
test("does not render when the site setting is disabled", async function (assert) {
|
|
this.siteSettings.chat_pinned_messages = false;
|
|
this.channel.pinnedMessagesCount = 2;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 2)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").doesNotExist();
|
|
});
|
|
|
|
test("renders the most recent pin with no indicator for a single pin", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").exists();
|
|
assert.dom(".chat-pinned-bar__excerpt").hasText("Pinned excerpt 0");
|
|
assert.dom(".chat-pinned-bar__indicator").doesNotExist();
|
|
});
|
|
|
|
test("renders the links the pin excerpt keeps", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
excerptPinResponse("See <a href='/t/topic/1'>the topic</a> for details")
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("See the topic for details");
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt a")
|
|
.hasAttribute("href", "/t/topic/1", "the link survives");
|
|
});
|
|
|
|
test("renders a URL-only pin as a link", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
excerptPinResponse(
|
|
'<a href="https://example.com/docs" rel="noopener nofollow ugc">https://example.com/docs</a>'
|
|
)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt a")
|
|
.hasAttribute("href", "https://example.com/docs")
|
|
.hasAttribute("rel", "noopener nofollow ugc");
|
|
});
|
|
|
|
test("skips pins whose message the host hides from the list", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 2;
|
|
this.hiddenMessageIds = new Set([201]);
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 2)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
@hiddenMessageIds={{this.hiddenMessageIds}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 1", "falls back to the newest visible pin");
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.doesNotExist("the hidden pin is not counted");
|
|
});
|
|
|
|
test("shows nothing when every pin is hidden", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
this.hiddenMessageIds = new Set([200]);
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
@hiddenMessageIds={{this.hiddenMessageIds}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").hasClass("--loading");
|
|
assert.dom(".chat-pinned-bar__main").doesNotExist();
|
|
});
|
|
|
|
test("shows a position indicator for multiple pins", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 3;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 3)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__indicator-segment").exists({ count: 3 });
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator-thumb")
|
|
.exists({ count: 1 }, "a single bright bar marks the active pin");
|
|
// oldest-first layout: the newest pin is active at the last index (2 of 3)
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.hasAttribute(
|
|
"style",
|
|
/--chat-pinned-bar-active:\s*2/,
|
|
"starts on the newest pin, in the bottom slot"
|
|
);
|
|
|
|
await click(".chat-pinned-bar__jump");
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.hasAttribute(
|
|
"style",
|
|
/--chat-pinned-bar-active:\s*1/,
|
|
"advancing to an older pin moves the highlight up a slot"
|
|
);
|
|
});
|
|
|
|
test("scrolls the indicator window when there are more pins than fit", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 8;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 8)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
// newest pin is active at index 7; the 4-wide window centres on it:
|
|
// top = min(7 - 2, 8 - 4) = 4 (scrolled to the bottom)
|
|
assert.dom(".chat-pinned-bar__indicator-segment").exists({ count: 8 });
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.hasAttribute(
|
|
"style",
|
|
/indicator-top:\s*4/,
|
|
"window starts at the bottom"
|
|
);
|
|
|
|
// advance toward older pins — the window scrolls up
|
|
for (let i = 0; i < 6; i++) {
|
|
await click(".chat-pinned-bar__jump");
|
|
}
|
|
|
|
// 6 taps back => active index 1 => top = 1 - 2 clamps to 0
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.hasAttribute(
|
|
"style",
|
|
/indicator-top:\s*0/,
|
|
"rail scrolled toward the oldest pin"
|
|
);
|
|
});
|
|
|
|
test("tapping jumps to the shown pin and previews the next", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 2;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 2)
|
|
);
|
|
|
|
let jumpedTo = null;
|
|
this.onJump = (messageId) => (jumpedTo = messageId);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.onJump}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
// opens on the newest pin (message 201)
|
|
assert.dom(".chat-pinned-bar__excerpt").hasText("Pinned excerpt 0");
|
|
|
|
await click(".chat-pinned-bar__jump");
|
|
|
|
assert.strictEqual(jumpedTo, 201, "jumps to the pin that was shown");
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 1", "and previews the next older pin");
|
|
|
|
await click(".chat-pinned-bar__jump");
|
|
|
|
assert.strictEqual(jumpedTo, 200, "jumps to that previewed pin");
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 0", "and previews back to the newest (wraps)");
|
|
});
|
|
|
|
test("anchors the active pin to the scroll position", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 3;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 3)
|
|
);
|
|
// message ids: 202 (excerpt 0, newest) / 201 (excerpt 1) / 200 (excerpt 2)
|
|
const view = new (class {
|
|
@tracked bottomId = null;
|
|
})();
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
@viewportBottomMessageId={{view.bottomId}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 0", "defaults to the newest pin");
|
|
|
|
view.bottomId = 201;
|
|
await settled();
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 1", "follows the pin governing the view");
|
|
|
|
view.bottomId = 100; // above every pin
|
|
await settled();
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Pinned excerpt 2", "falls back to the oldest pin");
|
|
});
|
|
|
|
test("links to the full pinned messages list via the see-all icon", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 2;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 2)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__see-all").exists();
|
|
assert
|
|
.dom(".chat-pinned-bar__see-all")
|
|
.hasAttribute("href", new RegExp(`/${this.channel.id}/pins$`));
|
|
});
|
|
|
|
test("shows an inline dismiss instead of the see-all icon for a single pin", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__see-all").doesNotExist();
|
|
assert.dom(".chat-pinned-bar__dismiss").exists();
|
|
|
|
await click(".chat-pinned-bar__dismiss");
|
|
|
|
assert.dom(".chat-pinned-bar").hasClass("--dismissed");
|
|
});
|
|
|
|
test("keeps the see-all icon for pin managers with a single pin", async function (assert) {
|
|
this.channel.meta.can_manage_pins = true;
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__dismiss").doesNotExist();
|
|
assert.dom(".chat-pinned-bar__see-all").exists();
|
|
});
|
|
|
|
test("shows an unread indicator when there are unseen pins", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 2;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 2)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__unread-indicator").doesNotExist();
|
|
|
|
this.channel.currentUserMembership = { has_unseen_pins: true };
|
|
await settled();
|
|
|
|
assert.dom(".chat-pinned-bar__unread-indicator").exists();
|
|
});
|
|
|
|
test("renders the server excerpt as decoded HTML, not double-escaped", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
response({
|
|
pinned_messages: [
|
|
{
|
|
id: 100,
|
|
chat_message_id: 200,
|
|
pinned_at: moment().toISOString(),
|
|
pinned_by: { id: 1, username: "alice" },
|
|
// server excerpts arrive as entity-encoded HTML
|
|
message: { id: 200, excerpt: "Rules & etiquette…" },
|
|
},
|
|
],
|
|
membership: null,
|
|
})
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText(
|
|
"Rules & etiquette…",
|
|
"decodes entities rather than escaping them"
|
|
);
|
|
});
|
|
|
|
test("reloads pins on a pin/unpin message bus event", async function (assert) {
|
|
let count = 1;
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, count)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator")
|
|
.doesNotExist("starts with a single pin and no indicator");
|
|
|
|
// another message gets pinned elsewhere
|
|
count = 2;
|
|
await publishToMessageBus(`/chat/${this.channel.id}`, {
|
|
type: "pin",
|
|
chat_message_id: 201,
|
|
});
|
|
await settled();
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__indicator-segment")
|
|
.exists({ count: 2 }, "refetches and reflects both pins");
|
|
});
|
|
|
|
test("updates the preview when a pinned message is edited", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
let edited = false;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
edited
|
|
? excerptPinResponse("Edited <a href='/t/1'>excerpt</a>")
|
|
: pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar__excerpt").hasText("Pinned excerpt 0");
|
|
|
|
// the pinned message (id 200) is edited
|
|
edited = true;
|
|
await publishToMessageBus(`/chat/${this.channel.id}`, {
|
|
type: "edit",
|
|
chat_message: { id: 200, message: "edited", excerpt: "Edited excerpt" },
|
|
});
|
|
await settled();
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt")
|
|
.hasText("Edited excerpt", "refetches instead of using the stripped one");
|
|
assert
|
|
.dom(".chat-pinned-bar__excerpt a")
|
|
.hasAttribute("href", "/t/1", "and keeps the links the refetch returned");
|
|
});
|
|
|
|
test("ignores edits to messages that are not pinned", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinResponse(this.channel, 1)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
// a different (unpinned) message is edited
|
|
await publishToMessageBus(`/chat/${this.channel.id}`, {
|
|
type: "edit",
|
|
chat_message: { id: 999, message: "x", excerpt: "Should not appear" },
|
|
});
|
|
await settled();
|
|
|
|
assert.dom(".chat-pinned-bar__excerpt").hasText("Pinned excerpt 0");
|
|
});
|
|
|
|
test("hides the bar when dismissed above the newest pin", async function (assert) {
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
dismissablePinResponse(100)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").doesNotHaveClass("--dismissed");
|
|
|
|
this.channel.pinsDismissedAboveId = 100; // the newest pin's id
|
|
await settled();
|
|
|
|
assert.dom(".chat-pinned-bar").hasClass("--dismissed");
|
|
});
|
|
|
|
test("reappears once a pin newer than the dismissed one is added", async function (assert) {
|
|
let pinId = 100;
|
|
this.channel.pinnedMessagesCount = 1;
|
|
this.channel.pinsDismissedAboveId = 100;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
dismissablePinResponse(pinId)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar")
|
|
.hasClass("--dismissed", "stays hidden while no newer pin exists");
|
|
|
|
// a newer pin (higher id) is added
|
|
pinId = 101;
|
|
await publishToMessageBus(`/chat/${this.channel.id}`, {
|
|
type: "pin",
|
|
chat_message_id: 201,
|
|
});
|
|
await settled();
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar")
|
|
.doesNotHaveClass("--dismissed", "reappears for the newer pin");
|
|
assert.strictEqual(
|
|
this.channel.pinsDismissedAboveId,
|
|
null,
|
|
"clears the stale dismissal so the navbar re-show button doesn't linger"
|
|
);
|
|
});
|
|
|
|
test("stays dismissed after reload via stored state", async function (assert) {
|
|
// simulate a previous dismissal persisted to local storage
|
|
const store = new KeyValueStore(STORE_NAMESPACE);
|
|
store.setObject({ key: String(this.channel.id), value: 100 });
|
|
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
dismissablePinResponse(100)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").hasClass("--dismissed");
|
|
});
|
|
|
|
test("pin managers bypass a stored dismissal", async function (assert) {
|
|
// a dismissal recorded before the user could manage pins
|
|
const store = new KeyValueStore(STORE_NAMESPACE);
|
|
store.setObject({ key: String(this.channel.id), value: 100 });
|
|
this.channel.meta.can_manage_pins = true;
|
|
|
|
this.channel.pinnedMessagesCount = 1;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
dismissablePinResponse(100)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar")
|
|
.doesNotHaveClass("--dismissed", "managers always see the bar");
|
|
});
|
|
|
|
test("stays dismissed when the dismissed pin is unpinned", async function (assert) {
|
|
let ids = [101, 100]; // newest-first
|
|
this.channel.pinnedMessagesCount = 2;
|
|
this.channel.pinsDismissedAboveId = 101;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinsResponse(ids)
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert.dom(".chat-pinned-bar").hasClass("--dismissed");
|
|
|
|
// the newest pin is unpinned, leaving only an older (lower-id) pin
|
|
ids = [100];
|
|
await publishToMessageBus(`/chat/${this.channel.id}`, {
|
|
type: "unpin",
|
|
chat_message_id: 301,
|
|
});
|
|
await settled();
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar")
|
|
.hasClass("--dismissed", "stays hidden — a removal is not a new pin");
|
|
});
|
|
|
|
test("uses the highest pin id, not the first pin, for dismissal", async function (assert) {
|
|
// pins[0] is first by display order but has a LOWER id than another pin
|
|
// (e.g. created_at not monotonic with id) — the bar must compare the max id
|
|
this.channel.pinnedMessagesCount = 2;
|
|
this.channel.pinsDismissedAboveId = 5;
|
|
pretender.get(`/chat/api/channels/${this.channel.id}/pins`, () =>
|
|
pinsResponse([5, 100])
|
|
);
|
|
|
|
await render(
|
|
<template>
|
|
<ChatPinnedMessageBar
|
|
@channel={{this.channel}}
|
|
@onJumpToMessage={{this.noop}}
|
|
/>
|
|
</template>
|
|
);
|
|
|
|
assert
|
|
.dom(".chat-pinned-bar")
|
|
.doesNotHaveClass(
|
|
"--dismissed",
|
|
"shown because a pin with a higher id than the dismissed value exists"
|
|
);
|
|
});
|
|
});
|
