mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-07 05:15:58 +08:00
89f26da39d
Ruby's compact module syntax (`module Migrations::Database::Schema::DSL`) breaks lexical constant lookup — `Module.nesting` only includes the innermost constant, so every cross-module reference must be fully qualified. In practice this means writing `Migrations::Database::Schema::Helpers` even when you're already inside `Migrations::Database::Schema`. Nested module definitions restore the full nesting chain, which brings several practical benefits: - **Less verbose code**: references like `Schema::Helpers`, `Database::IntermediateDB`, or `Converters::Base::ProgressStep` work without repeating the full path from root - **Easier to write new code**: contributors don't need to remember which prefixes are required — if you're inside the namespace, short names just work - **Fewer aliasing workarounds**: removes the need for constants like `MappingType = Migrations::Importer::MappingType` that existed solely to shorten references - **Standard Ruby style**: consistent with how most Ruby projects and gems structure their namespaces The diff is large but mechanical — no logic changes, just module wrapping and shortening references that the nesting now resolves. Generated code (intermediate_db models/enums) keeps fully qualified references like `Migrations::Database.format_*` since it must work regardless of the configured output namespace. - Convert 138 lib files from compact to nested module definitions - Remove now-redundant fully qualified prefixes and aliases - Update model and enum writers to generate nested modules with correct indentation - Regenerate all intermediate_db models and enums
31 lines
648 B
Ruby
31 lines
648 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Migrations
|
|
module Database
|
|
class OfflineConnection
|
|
def initialize
|
|
@parametrized_insert_statements = []
|
|
end
|
|
|
|
def close
|
|
@parametrized_insert_statements = nil
|
|
end
|
|
|
|
def closed?
|
|
@parametrized_insert_statements.nil?
|
|
end
|
|
|
|
def insert(sql, parameters = [])
|
|
@parametrized_insert_statements << [sql, parameters]
|
|
end
|
|
|
|
def parametrized_insert_statements
|
|
@parametrized_insert_statements
|
|
end
|
|
|
|
def clear!
|
|
@parametrized_insert_statements.clear if @parametrized_insert_statements
|
|
end
|
|
end
|
|
end
|
|
end
|
