mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-05 15:59:29 +08:00
89f26da39d
Ruby's compact module syntax (`module Migrations::Database::Schema::DSL`) breaks lexical constant lookup — `Module.nesting` only includes the innermost constant, so every cross-module reference must be fully qualified. In practice this means writing `Migrations::Database::Schema::Helpers` even when you're already inside `Migrations::Database::Schema`. Nested module definitions restore the full nesting chain, which brings several practical benefits: - **Less verbose code**: references like `Schema::Helpers`, `Database::IntermediateDB`, or `Converters::Base::ProgressStep` work without repeating the full path from root - **Easier to write new code**: contributors don't need to remember which prefixes are required — if you're inside the namespace, short names just work - **Fewer aliasing workarounds**: removes the need for constants like `MappingType = Migrations::Importer::MappingType` that existed solely to shorten references - **Standard Ruby style**: consistent with how most Ruby projects and gems structure their namespaces The diff is large but mechanical — no logic changes, just module wrapping and shortening references that the nesting now resolves. Generated code (intermediate_db models/enums) keeps fully qualified references like `Migrations::Database.format_*` since it must work regardless of the configured output namespace. - Convert 138 lib files from compact to nested module definitions - Remove now-redundant fully qualified prefixes and aliases - Update model and enum writers to generate nested modules with correct indentation - Regenerate all intermediate_db models and enums
113 lines
3.7 KiB
Ruby
113 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# This file is auto-generated from the IntermediateDB schema. To make changes,
|
|
# update the configuration files in "migrations/config/schema/" and then run
|
|
# `migrations/bin/cli schema generate` to regenerate this file.
|
|
|
|
module Migrations
|
|
module Database
|
|
module IntermediateDB
|
|
module Topic
|
|
SQL = <<~SQL
|
|
INSERT INTO topics (
|
|
original_id,
|
|
archetype,
|
|
archived,
|
|
bannered_until,
|
|
category_id,
|
|
closed,
|
|
created_at,
|
|
deleted_at,
|
|
deleted_by_id,
|
|
external_id,
|
|
featured_link,
|
|
pinned_at,
|
|
pinned_globally,
|
|
pinned_until,
|
|
subtype,
|
|
title,
|
|
user_id,
|
|
views,
|
|
visibility_reason_id,
|
|
visible
|
|
)
|
|
VALUES (
|
|
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
|
|
)
|
|
SQL
|
|
private_constant :SQL
|
|
|
|
# Creates a new `topics` record in the IntermediateDB.
|
|
#
|
|
# @param original_id [Integer, String]
|
|
# @param archetype [String, nil]
|
|
# @param archived [Boolean, nil]
|
|
# @param bannered_until [Time, nil]
|
|
# @param category_id [Integer, String, nil]
|
|
# @param closed [Boolean, nil]
|
|
# @param created_at [Time, nil]
|
|
# @param deleted_at [Time, nil]
|
|
# @param deleted_by_id [Integer, String, nil]
|
|
# @param external_id [Integer, String, nil]
|
|
# @param featured_link [String, nil]
|
|
# @param pinned_at [Time, nil]
|
|
# @param pinned_globally [Boolean, nil]
|
|
# @param pinned_until [Time, nil]
|
|
# @param subtype [String, nil]
|
|
# @param title [String]
|
|
# @param user_id [Integer, String, nil]
|
|
# @param views [Integer, nil]
|
|
# @param visibility_reason_id [Integer, String, nil]
|
|
# @param visible [Boolean, nil]
|
|
#
|
|
# @return [void]
|
|
def self.create(
|
|
original_id:,
|
|
archetype: nil,
|
|
archived: nil,
|
|
bannered_until: nil,
|
|
category_id: nil,
|
|
closed: nil,
|
|
created_at: nil,
|
|
deleted_at: nil,
|
|
deleted_by_id: nil,
|
|
external_id: nil,
|
|
featured_link: nil,
|
|
pinned_at: nil,
|
|
pinned_globally: nil,
|
|
pinned_until: nil,
|
|
subtype: nil,
|
|
title:,
|
|
user_id: nil,
|
|
views: nil,
|
|
visibility_reason_id: nil,
|
|
visible: nil
|
|
)
|
|
Migrations::Database::IntermediateDB.insert(
|
|
SQL,
|
|
original_id,
|
|
archetype,
|
|
Migrations::Database.format_boolean(archived),
|
|
Migrations::Database.format_datetime(bannered_until),
|
|
category_id,
|
|
Migrations::Database.format_boolean(closed),
|
|
Migrations::Database.format_datetime(created_at),
|
|
Migrations::Database.format_datetime(deleted_at),
|
|
deleted_by_id,
|
|
external_id,
|
|
featured_link,
|
|
Migrations::Database.format_datetime(pinned_at),
|
|
Migrations::Database.format_boolean(pinned_globally),
|
|
Migrations::Database.format_datetime(pinned_until),
|
|
subtype,
|
|
title,
|
|
user_id,
|
|
views,
|
|
visibility_reason_id,
|
|
Migrations::Database.format_boolean(visible),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
