mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-06 02:10:08 +08:00
89f26da39d
Ruby's compact module syntax (`module Migrations::Database::Schema::DSL`) breaks lexical constant lookup — `Module.nesting` only includes the innermost constant, so every cross-module reference must be fully qualified. In practice this means writing `Migrations::Database::Schema::Helpers` even when you're already inside `Migrations::Database::Schema`. Nested module definitions restore the full nesting chain, which brings several practical benefits: - **Less verbose code**: references like `Schema::Helpers`, `Database::IntermediateDB`, or `Converters::Base::ProgressStep` work without repeating the full path from root - **Easier to write new code**: contributors don't need to remember which prefixes are required — if you're inside the namespace, short names just work - **Fewer aliasing workarounds**: removes the need for constants like `MappingType = Migrations::Importer::MappingType` that existed solely to shorten references - **Standard Ruby style**: consistent with how most Ruby projects and gems structure their namespaces The diff is large but mechanical — no logic changes, just module wrapping and shortening references that the nesting now resolves. Generated code (intermediate_db models/enums) keeps fully qualified references like `Migrations::Database.format_*` since it must work regardless of the configured output namespace. - Convert 138 lib files from compact to nested module definitions - Remove now-redundant fully qualified prefixes and aliases - Update model and enum writers to generate nested modules with correct indentation - Regenerate all intermediate_db models and enums
47 lines
1.1 KiB
Ruby
47 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Migrations
|
|
module Converters
|
|
module Base
|
|
class Step
|
|
IntermediateDB = Database::IntermediateDB
|
|
Enums = Database::IntermediateDB::Enums
|
|
|
|
attr_accessor :settings
|
|
attr_reader :tracker
|
|
|
|
# inside of Step it might make more sense to access it as `step` instead of `tracker`
|
|
alias step tracker
|
|
|
|
def initialize(tracker, args = {})
|
|
@tracker = tracker
|
|
|
|
args.each do |arg, value|
|
|
setter = "#{arg}=".to_sym
|
|
public_send(setter, value) if respond_to?(setter, true)
|
|
end
|
|
end
|
|
|
|
def execute
|
|
# do nothing
|
|
end
|
|
|
|
class << self
|
|
def title(
|
|
value = (
|
|
getter = true
|
|
nil
|
|
)
|
|
)
|
|
@title = value unless getter
|
|
@title.presence ||
|
|
I18n.t(
|
|
"converter.default_step_title",
|
|
type: name&.demodulize&.underscore&.humanize(capitalize: false),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
