mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-05 05:30:44 +08:00
89f26da39d
Ruby's compact module syntax (`module Migrations::Database::Schema::DSL`) breaks lexical constant lookup — `Module.nesting` only includes the innermost constant, so every cross-module reference must be fully qualified. In practice this means writing `Migrations::Database::Schema::Helpers` even when you're already inside `Migrations::Database::Schema`. Nested module definitions restore the full nesting chain, which brings several practical benefits: - **Less verbose code**: references like `Schema::Helpers`, `Database::IntermediateDB`, or `Converters::Base::ProgressStep` work without repeating the full path from root - **Easier to write new code**: contributors don't need to remember which prefixes are required — if you're inside the namespace, short names just work - **Fewer aliasing workarounds**: removes the need for constants like `MappingType = Migrations::Importer::MappingType` that existed solely to shorten references - **Standard Ruby style**: consistent with how most Ruby projects and gems structure their namespaces The diff is large but mechanical — no logic changes, just module wrapping and shortening references that the nesting now resolves. Generated code (intermediate_db models/enums) keeps fully qualified references like `Migrations::Database.format_*` since it must work regardless of the configured output namespace. - Convert 138 lib files from compact to nested module definitions - Remove now-redundant fully qualified prefixes and aliases - Update model and enum writers to generate nested modules with correct indentation - Regenerate all intermediate_db models and enums
34 lines
803 B
Ruby
34 lines
803 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Migrations
|
|
module Converters
|
|
module Base
|
|
class ParallelJob
|
|
def initialize(step)
|
|
@step = step
|
|
@tracker = step.tracker
|
|
|
|
@offline_connection = Database::OfflineConnection.new
|
|
|
|
ForkManager.after_fork_child { Database::IntermediateDB.setup(@offline_connection) }
|
|
end
|
|
|
|
def run(item)
|
|
@tracker.reset_stats!
|
|
@offline_connection.clear!
|
|
|
|
begin
|
|
@step.process_item(item)
|
|
rescue StandardError => e
|
|
@tracker.log_error("Failed to process item", exception: e, details: item)
|
|
end
|
|
|
|
[@offline_connection.parametrized_insert_statements, @tracker.stats]
|
|
end
|
|
|
|
def cleanup
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
