mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-08 15:18:58 +08:00
6096c3551b
Reddit increasingly blocks server-side fetches from Discourse instances, which makes the current Reddit onebox path unreliable. This switches Reddit oneboxes to Reddit's native embed path instead of trying to fetch and render post metadata on the server. Changes: - replace the Reddit onebox engine with a native `embed.reddit.com` iframe - listen for Reddit resize messages so embeds grow to the correct height - remove the now-unused Reddit OAuth site settings and auth mixin - update Reddit onebox specs and add a JS unit test for the resize handler Screenshots: <img width="704" height="1861" alt="image" src="https://github.com/user-attachments/assets/ce332dfb-c76b-4700-ab26-fae9123cbd8c" />
78 lines
1.7 KiB
Ruby
78 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Onebox
|
|
module Engine
|
|
class RedditMediaOnebox
|
|
include Engine
|
|
|
|
always_https
|
|
requires_iframe_origins "https://embed.reddit.com", "https://sh.reddit.com"
|
|
matches_domain(
|
|
"reddit.com",
|
|
"www.reddit.com",
|
|
"old.reddit.com",
|
|
"np.reddit.com",
|
|
"new.reddit.com",
|
|
)
|
|
|
|
def self.matches_path(path)
|
|
path.match?(%r{^/(?:r|user)/[^/]+/comments/[^/]+})
|
|
end
|
|
|
|
def to_html
|
|
<<~HTML
|
|
<iframe
|
|
class="reddit-onebox"
|
|
src="#{embed_url}"
|
|
width="640"
|
|
height="#{default_height}"
|
|
allowfullscreen
|
|
></iframe>
|
|
HTML
|
|
end
|
|
|
|
def placeholder_html
|
|
Onebox::Helpers.generic_placeholder_html
|
|
end
|
|
|
|
private
|
|
|
|
def embed_url
|
|
@embed_url ||=
|
|
Onebox::Helpers.normalize_url_for_output(
|
|
URI::HTTPS.build(
|
|
host: "embed.reddit.com",
|
|
path: normalized_path,
|
|
query: URI.encode_www_form(embed_params),
|
|
).to_s,
|
|
)
|
|
end
|
|
|
|
def normalized_path
|
|
return "#{uri.path}/" unless uri.path.end_with?("/")
|
|
uri.path
|
|
end
|
|
|
|
def embed_params
|
|
params = { embed: true, ref_source: "embed", ref: "share" }
|
|
|
|
if comment_path?
|
|
params[:showmedia] = false
|
|
params[:showmore] = false
|
|
params[:depth] = 1
|
|
params[:context] = 1
|
|
end
|
|
|
|
params
|
|
end
|
|
|
|
def comment_path?
|
|
uri.path.match?(%r{^/(?:r|user)/[^/]+/comments/[^/]+/[^/]*/[^/]+/?$})
|
|
end
|
|
|
|
def default_height
|
|
comment_path? ? 300 : 500
|
|
end
|
|
end
|
|
end
|
|
end
|
