discourse/spec/system/topic_list_spec.rb
Jarek Radosz e1265db0d9
DEV: Fix a topic list spec flake (#39991)
3-word title didn't always clear the min title length
2026-05-13 20:36:04 +02:00

157 lines
4.9 KiB
Ruby

# frozen_string_literal: true
describe "Topic list" do
fab!(:topics) { Fabricate.times(10, :post).map(&:topic) }
fab!(:admin)
before_all do
sidebar_url = Fabricate(:sidebar_url, name: "my topic link", value: "/t/#{topics[4].id}")
Fabricate(
:sidebar_section_link,
sidebar_section:
SidebarSection.find_by(section_type: SidebarSection.section_types[:community]),
linkable: sidebar_url,
)
end
let(:discovery) { PageObjects::Pages::Discovery.new }
let(:topic) { PageObjects::Pages::Topic.new }
def focussed_topic_id
page.evaluate_script(
"document.activeElement.closest('.topic-list-item')?.dataset.topicId",
)&.to_i
end
def focussed_post_id
page.evaluate_script("document.activeElement.closest('.onscreen-post')?.dataset.postId")&.to_i
end
it "refocusses last clicked topic when going back to topic list" do
visit("/latest")
expect(page).to have_css("body.navigation-topics")
expect(discovery.topic_list).to have_topics
# Click a topic
discovery.topic_list.visit_topic(topics[5])
expect(topic).to have_topic_title(topics[5].title)
# Going back to the topic-list should re-focus
page.go_back
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(topics[5].id)
# Click topic again
discovery.topic_list.visit_topic(topics[5])
expect(topic).to have_topic_title(topics[5].title)
# Visiting a topic list another way should not focus
find(".sidebar-section-link[data-link-name='everything']").click
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(nil)
end
it "refocusses properly when navigating via the 'last activity' link" do
visit("/latest")
# Visit topic via activity column and keyboard
discovery.topic_list.visit_topic_last_reply_via_keyboard(topics[2])
expect(topic).to have_topic_title(topics[2].title)
# Going back to the topic-list should re-focus
page.go_back
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(topics[2].id)
# Visit topic via keyboard using posts map (OP button)
discovery.topic_list.visit_topic_first_reply_via_keyboard(topics[4])
expect(topic).to have_topic_title(topics[4].title)
# Going back to the topic-list should re-focus
page.go_back
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(topics[4].id)
end
it "does not refocus topic when visiting via something other than topic list" do
visit("/latest")
# Clicking sidebar link should visit topic
find(".sidebar-section-link[data-link-name='my topic link']").click
expect(topic).to have_topic_title(topics[4].title)
# Going back to the topic-list should not re-focus
page.go_back
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(nil)
end
it "refocusses properly when there are multiple pages of topics" do
Fabricate.times(25, :post).map(&:topic)
oldest_topic = Fabricate(:post).topic
oldest_topic.update(bumped_at: 1.day.ago)
visit("/latest")
# Scroll to bottom for infinite load
page.execute_script <<~JS
document.querySelectorAll('.topic-list-item')[24].scrollIntoView(true);
JS
# Click a topic
discovery.topic_list.visit_topic(oldest_topic)
expect(topic).to have_topic_title(oldest_topic.title)
# Going back to the topic-list should re-focus
page.go_back
expect(page).to have_css("body.navigation-topics")
expect(focussed_topic_id).to eq(oldest_topic.id)
end
it "opens topic in new window when pressing meta+Enter" do
visit("/latest")
expect(discovery.topic_list).to have_topics
new_window =
window_opened_by { discovery.topic_list.send_keys_to_topic(topics[5], %i[meta return]) }
within_window(new_window) { expect(topic).to have_topic_title(topics[5].title) }
end
it "shows a topic list" do
sign_in(admin)
users =
8.times.map do
Fabricate(:user, username: Faker::Internet.username(specifier: 6..15, separators: %w[_ .]))
end
categories = 5.times.map { Fabricate(:category) }
25.times do
views = rand(80..8_000)
topic =
Fabricate(
:topic,
title: Faker::Lorem.sentence(word_count: rand(6..12)).chomp("."),
category: categories.sample,
)
Fabricate(:post, topic: topic)
rand(2..5).times { Fabricate(:post, topic: topic, user: users.sample) }
topic.feature_topic_users
topic.update!(views: views, like_count: rand(views / 100..views / 4))
end
visit("/latest")
expect(discovery.topic_list).to have_topics
screenshot_marker(label: "topic-list")
visit "/categories"
screenshot_marker(label: "categories")
find("#create-topic").click
expect(page).to have_css("#reply-control.open")
screenshot_marker(label: "composer-new-topic")
end
end