Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-19 00:22:49 +08:00
Code Packages Activity Actions
discourse/spec/system/page_objects/components/review
History
Exact
Régis Hanol 298c0208e6
FIX: Use replacement icon class for all dot-namespaced icon IDs (#38713) 
The reply icon in the user menu was not being flipped for RTL languages.
The RTL stylesheet targets `.d-icon-reply` with `transform: scaleX(-1)`,
but the icon rendered with class `d-icon-user_menu.replies` instead —
the dot made the CSS selector never match.

The `iconClasses` function only replaced dotted icon IDs with their
mapped replacement for class names when the ID contained
"notification.". Other namespaced IDs like "user_menu.replies" and
"user_menu.drafts" were used as-is, producing invalid CSS class names.

Broadened the condition to replace any icon ID containing a dot, since
dots are invalid in CSS class selectors regardless of the namespace.

**BEFORE**

<img width="1376" height="1164" alt="2026-03-19 @ 09 52 09"
src="https://github.com/user-attachments/assets/dbc2be67-2bdf-416e-9eff-c99593af66f8"
/>

**AFTER**

<img width="1376" height="1164" alt="2026-03-19 @ 09 52 00"
src="https://github.com/user-attachments/assets/11ecfcc9-2935-4f10-af78-55a9bb3cb4aa"
/>


https://meta.discourse.org/t/398766
2026-03-20 09:50:15 +01:00
..
flag_reason.rb UX: update heading style in review queue refresh (#36391) 2025-12-02 16:54:00 -05:00
topic_link.rb FIX: Use replacement icon class for all dot-namespaced icon IDs (#38713) 2026-03-20 09:50:15 +01:00