mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-24 18:43:51 +08:00
df0cfc4dbe
- Removes double private keyword - Fixes test mutating json as string, instead of json as hash. Calling `string["description"] = ""` uses Ruby’s `String#[]=` method which finds the substring `description` and replaces it with `""`, corrupting the JSON but leaving it parseable with a `nil` description field instead of `""`.
104 lines
3.5 KiB
Ruby
Vendored
104 lines
3.5 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Onebox::Engine::GithubRepoOnebox do
|
|
let(:gh_link) { "https://github.com/discourse/discourse" }
|
|
let(:api_uri) { "https://api.github.com/repos/discourse/discourse" }
|
|
let(:response) { onebox_response(described_class.onebox_name) }
|
|
|
|
before { stub_request(:get, api_uri).to_return(status: 200, body: response) }
|
|
|
|
include_context "with engines" do
|
|
let(:link) { gh_link }
|
|
end
|
|
it_behaves_like "an engine"
|
|
|
|
describe "#to_html" do
|
|
it "includes the description of the repo" do
|
|
expect(html).to include("A platform for community discussion. Free, open, simple.")
|
|
end
|
|
|
|
it "includes the name of the repo and truncated description for the title" do
|
|
expect(html).to include(
|
|
"GitHub - discourse/discourse: A platform for community discussion. Free, open,...",
|
|
)
|
|
end
|
|
|
|
it "includes a thumbnail url" do
|
|
SecureRandom.stubs(:hex).returns("1234")
|
|
expect(html).to include("https://opengraph.githubassets.com/1234/discourse/discourse")
|
|
end
|
|
|
|
it "sets the data-github-private-repo attr to false" do
|
|
expect(html).to include("data-github-private-repo=\"false\"")
|
|
end
|
|
|
|
context "when the PR is in a private repo" do
|
|
let(:response) do
|
|
resp = MultiJson.load(onebox_response(described_class.onebox_name))
|
|
resp["private"] = true
|
|
MultiJson.dump(resp)
|
|
end
|
|
|
|
it "sets the data-github-private-repo attr to true" do
|
|
expect(html).to include("data-github-private-repo=\"true\"")
|
|
end
|
|
end
|
|
|
|
context "when the repo has no description" do
|
|
let(:response) do
|
|
resp = MultiJson.load(onebox_response(described_class.onebox_name))
|
|
resp["description"] = ""
|
|
MultiJson.dump(resp)
|
|
end
|
|
|
|
it "includes a message about contributing to the repo" do
|
|
expect(html).to include(I18n.t("onebox.github.no_description", repo: "discourse/discourse"))
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when github_onebox_access_token is configured" do
|
|
before { SiteSetting.github_onebox_access_tokens = "discourse|github_pat_1234" }
|
|
|
|
it "sends it as part of the request" do
|
|
html
|
|
expect(WebMock).to have_requested(:get, api_uri).with(
|
|
headers: {
|
|
"Authorization" => "Bearer github_pat_1234",
|
|
},
|
|
)
|
|
end
|
|
end
|
|
|
|
describe ".===" do
|
|
it "matches valid GitHub repository URL" do
|
|
valid_url = URI("https://github.com/username/repository/")
|
|
expect(described_class === valid_url).to eq(true)
|
|
end
|
|
|
|
it "matches valid GitHub repository URL without trailing slash" do
|
|
valid_url_without_slash = URI("https://github.com/username/repository")
|
|
expect(described_class === valid_url_without_slash).to eq(true)
|
|
end
|
|
|
|
it "matches valid GitHub repository URL with www" do
|
|
valid_url_with_www = URI("https://www.github.com/username/repository/")
|
|
expect(described_class === valid_url_with_www).to eq(true)
|
|
end
|
|
|
|
it "does not match Gist URL" do
|
|
gist_url = URI("https://gist.github.com/username/123456")
|
|
expect(described_class === gist_url).to eq(false)
|
|
end
|
|
|
|
it "does not match URL with valid domain as part of another domain" do
|
|
malicious_url = URI("https://github.com.malicious.com/username/repository/")
|
|
expect(described_class === malicious_url).to eq(false)
|
|
end
|
|
|
|
it "does not match invalid path" do
|
|
invalid_path_url = URI("https://github.com/username/repository/invalid")
|
|
expect(described_class === invalid_path_url).to eq(false)
|
|
end
|
|
end
|
|
end
|
