mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-03 22:38:10 +08:00
7d50a448ec
Previously, when viewing group assigned topics, users could see all private messages assigned to the group regardless of whether they were participants in those PMs. Changed `include_all_pms` to `include_pms` to respect PM participation rules, ensuring users only see assigned PMs they are actual participants in.
43 lines
1.4 KiB
Ruby
43 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "topic_view"
|
|
|
|
describe TopicQuery do
|
|
fab!(:user)
|
|
fab!(:admin)
|
|
fab!(:other_admin, :admin)
|
|
|
|
fab!(:user_pm) { Fabricate(:private_message_topic, user: user) }
|
|
fab!(:admin_pm) { Fabricate(:private_message_topic, user: admin) }
|
|
fab!(:other_admin_pm) { Fabricate(:private_message_topic, user: other_admin) }
|
|
|
|
fab!(:group)
|
|
|
|
describe "#list_group_topics_assigned" do
|
|
before do
|
|
SiteSetting.assign_enabled = true
|
|
|
|
[user, admin, other_admin].each { |user| group.add(user) }
|
|
|
|
[user_pm, admin_pm, other_admin_pm].each { |topic| Fabricate(:post, topic: topic) }
|
|
Fabricate(:topic_allowed_user, user: admin, topic: user_pm)
|
|
|
|
Assigner.new(user_pm, Discourse.system_user).assign(admin)
|
|
Assigner.new(admin_pm, Discourse.system_user).assign(admin)
|
|
Assigner.new(other_admin_pm, Discourse.system_user).assign(other_admin)
|
|
end
|
|
|
|
it "includes only PMs that users are participants in" do
|
|
expect(TopicQuery.new(user).list_group_topics_assigned(group).topics).to contain_exactly(
|
|
user_pm,
|
|
)
|
|
expect(TopicQuery.new(admin).list_group_topics_assigned(group).topics).to contain_exactly(
|
|
user_pm,
|
|
admin_pm,
|
|
)
|
|
expect(
|
|
TopicQuery.new(other_admin).list_group_topics_assigned(group).topics,
|
|
).to contain_exactly(other_admin_pm)
|
|
end
|
|
end
|
|
end
|
