mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-06 14:53:13 +08:00
4922c72ea7
Browser page view (BPV) are tracked currently via specific HTTP request headers which we attach on AJAX/MessageBus polling requests and refer to as the "piggyback" method or via the new dedicated `/srv/pv` endpoint when the `use_beacon_for_browser_page_views` site setting is enabled. For the "piggyback" method, details about the BPV request headers are never logged while the `/srv/pv` endpoint is handled by the `Middleware::RequestTracker` and never hits the Rails controllers. As a result, any attempt to debug errors with regards to BPV is hard because we have no visibility into how the actual params of these BPV related requests arrived at the server. This commit updates `Middleware::RequestTracker` to fire `process_action.action_controller` notification whenever a request results in BPV counters being incremented so that a log line lands in the configured Rails log file where the request's params field contains the attributes that was sent from the client. "piggyback" BPV requests are logged using a fake controller#action reference of "PageviewController#piggyback" while the beacon BPV requests are logged using a fake controller#action reference of "PageviewController#beacon". |
||
|---|---|---|
| .. | ||
| 000-active_record.rb | ||
| 000-development_reload_warnings.rb | ||
| 000-mini_racer.rb | ||
| 000-mini_sql.rb | ||
| 000-pg_connection_patch.rb | ||
| 000-post_migration.rb | ||
| 000-trace_pg_connections.rb | ||
| 000-zeitwerk.rb | ||
| 001-redis.rb | ||
| 002-freedom_patches.rb | ||
| 002-rails_failover.rb | ||
| 004-message_bus.rb | ||
| 005-site_settings.rb | ||
| 006-ensure_login_hint.rb | ||
| 006-mini_profiler.rb | ||
| 008-rack-cors.rb | ||
| 009-omniauth.rb | ||
| 012-category_types.rb | ||
| 012-web_hook_events.rb | ||
| 014-track-setting-changes.rb | ||
| 015-track-upcoming-change-toggle.rb | ||
| 099-anon-cache.rb | ||
| 099-drain_pool.rb | ||
| 100-active-support-type-extensions.rb | ||
| 100-custom-timezones.rb | ||
| 100-flags.rb | ||
| 100-i18n.rb | ||
| 100-logster.rb | ||
| 100-oj.rb | ||
| 100-onebox_options.rb | ||
| 100-push-notifications.rb | ||
| 100-quiet_logger.rb | ||
| 100-regex-timeout.rb | ||
| 100-secret_token.rb | ||
| 100-session_store.rb | ||
| 100-sidekiq.rb | ||
| 100-silence_logger.rb | ||
| 100-strong_parameters.rb | ||
| 100-verify_config.rb | ||
| 100-wrap_parameters.rb | ||
| 101-lograge.rb | ||
| 102-truncate-logs.rb | ||
| 200-first_middlewares.rb | ||
| 300-nested-replies.rb | ||
| 300-perf.rb | ||
| 400-deprecations.rb | ||
| 999-themes.rb | ||
| assets.rb | ||
| filter_parameter_logging.rb | ||
