mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
**Previously**, nothing was recorded when an admin completed or dismissed the onboarding panel. Because `enable_site_owner_onboarding` is a hidden setting, `SiteSetting#log` skipped it too, so there was no audit trail for how admins moved through the guide. **In this update**, each step completion, full onboarding completion, and panel dismissal writes a dedicated `UserHistory` staff action. | Before | After | | --- | --- | |  |  |
211 lines
6.3 KiB
Ruby
Vendored
211 lines
6.3 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe "Admin Onboarding Banner" do
|
|
fab!(:admin)
|
|
|
|
let(:banner) { PageObjects::Components::AdminOnboardingBanner.new }
|
|
let(:predefined_topics_modal) { PageObjects::Modals::AdminOnboardingPredefinedTopics.new }
|
|
let(:theme_picker_modal) { PageObjects::Modals::AdminOnboardingThemePicker.new }
|
|
let(:create_invite_modal) { PageObjects::Modals::CreateInvite.new }
|
|
let(:composer) { PageObjects::Components::Composer.new }
|
|
let(:toasts) { PageObjects::Components::Toasts.new }
|
|
|
|
before do
|
|
SiteSetting.enable_site_owner_onboarding = true
|
|
SiteSetting.default_theme_id = Theme.foundation_theme.id
|
|
|
|
sign_in(admin)
|
|
end
|
|
|
|
describe "banner visibility" do
|
|
it "shows the onboarding banner for admin users" do
|
|
visit("/")
|
|
expect(banner).to be_visible
|
|
end
|
|
|
|
it "shows all three onboarding steps" do
|
|
visit("/")
|
|
expect(banner.step("select_theme")).to be_present
|
|
expect(banner.step("invite_collaborators")).to be_present
|
|
expect(banner.step("start_posting")).to be_present
|
|
end
|
|
|
|
it "can close the banner prematurely" do
|
|
visit("/")
|
|
expect(banner).to be_visible
|
|
|
|
banner.close
|
|
|
|
expect(SiteSetting.enable_site_owner_onboarding).to eq(false)
|
|
try_until_success do
|
|
expect(
|
|
UserHistory.exists?(
|
|
action: UserHistory.actions[:admin_onboarding_dismissed],
|
|
acting_user_id: admin.id,
|
|
),
|
|
).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "start posting step" do
|
|
it "opens composer with selected topic and marks step as complete when topic is created" do
|
|
visit("/")
|
|
expect(banner.step_not_completed?("start_posting")).to eq(true)
|
|
|
|
banner.click_step_action("start_posting")
|
|
expect(predefined_topics_modal).to be_open
|
|
expect(predefined_topics_modal.topic_card_count).to eq(4)
|
|
|
|
predefined_topics_modal.select_topic(0)
|
|
|
|
expect(composer).to be_opened
|
|
expect(composer.composer_input.value).not_to be_empty
|
|
|
|
composer.composer_input.set("Testing topic selection")
|
|
composer.create
|
|
expect(page).to have_content("Testing topic selection")
|
|
|
|
visit("/")
|
|
expect(banner.step_completed?("start_posting")).to eq(true)
|
|
end
|
|
|
|
it "can cancel topic selection without completing step" do
|
|
visit("/")
|
|
banner.click_step_action("start_posting")
|
|
expect(predefined_topics_modal).to be_open
|
|
|
|
predefined_topics_modal.cancel
|
|
|
|
expect(predefined_topics_modal).to be_closed
|
|
expect(banner.step_not_completed?("start_posting")).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "invite collaborators step" do
|
|
it "marks step as complete after creating invite" do
|
|
visit("/")
|
|
expect(banner.step_not_completed?("invite_collaborators")).to eq(true)
|
|
|
|
banner.click_step_action("invite_collaborators")
|
|
|
|
expect(create_invite_modal).to be_open
|
|
create_invite_modal.save_button.click
|
|
expect(create_invite_modal).to have_copy_button
|
|
|
|
create_invite_modal.close
|
|
|
|
expect(banner.step_completed?("invite_collaborators")).to eq(true)
|
|
end
|
|
|
|
it "does not mark step complete if modal is cancelled" do
|
|
visit("/")
|
|
expect(banner.step_not_completed?("invite_collaborators")).to eq(true)
|
|
banner.click_step_action("invite_collaborators")
|
|
|
|
expect(create_invite_modal).to be_open
|
|
create_invite_modal.close
|
|
|
|
expect(banner.step_not_completed?("invite_collaborators")).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "select theme step" do
|
|
it "opens the theme picker modal" do
|
|
visit("/")
|
|
expect(banner.step_not_completed?("select_theme")).to eq(true)
|
|
|
|
banner.click_step_action("select_theme")
|
|
|
|
expect(theme_picker_modal).to be_open
|
|
expect(theme_picker_modal).to have_theme_cards(minimum: 1)
|
|
end
|
|
|
|
it "sets a theme as default and marks step complete" do
|
|
visit("/")
|
|
banner.click_step_action("select_theme")
|
|
|
|
expect(theme_picker_modal).to be_open
|
|
|
|
selected_name = theme_picker_modal.select_first_selectable_theme
|
|
|
|
# Page reloads after theme selection; wait for it to complete
|
|
expect(page).to have_css(".admin-onboarding-banner")
|
|
expect(banner.step_completed?("select_theme")).to eq(true)
|
|
expect(Theme.find(SiteSetting.default_theme_id).name).to eq(selected_name)
|
|
|
|
# the reload must not cancel the in-flight audit write
|
|
expect(
|
|
UserHistory.where(
|
|
action: UserHistory.actions[:admin_onboarding_step_completed],
|
|
acting_user_id: admin.id,
|
|
).pluck(:subject),
|
|
).to eq(["select_theme"])
|
|
end
|
|
end
|
|
|
|
describe "completing all steps" do
|
|
it "disables onboarding when select theme is completed last" do
|
|
visit("/")
|
|
|
|
banner.click_step_action("start_posting")
|
|
predefined_topics_modal.select_topic(0)
|
|
composer.create
|
|
visit("/")
|
|
|
|
expect(banner.step_completed?("start_posting")).to eq(true)
|
|
|
|
banner.click_step_action("invite_collaborators")
|
|
create_invite_modal.save_button.click
|
|
expect(create_invite_modal).to have_copy_button
|
|
create_invite_modal.close
|
|
|
|
expect(banner.step_completed?("invite_collaborators")).to eq(true)
|
|
|
|
banner.click_step_action("select_theme")
|
|
expect(theme_picker_modal).to be_open
|
|
theme_picker_modal.select_first_selectable_theme
|
|
|
|
# Page reloads after theme selection; banner disappears when all steps complete
|
|
expect(banner).to be_not_visible
|
|
expect(SiteSetting.enable_site_owner_onboarding).to eq(false)
|
|
|
|
try_until_success do
|
|
expect(
|
|
UserHistory.where(
|
|
action: UserHistory.actions[:admin_onboarding_step_completed],
|
|
acting_user_id: admin.id,
|
|
).pluck(:subject),
|
|
).to contain_exactly("start_posting", "invite_collaborators", "select_theme")
|
|
|
|
expect(
|
|
UserHistory.exists?(
|
|
action: UserHistory.actions[:admin_onboarding_completed],
|
|
acting_user_id: admin.id,
|
|
),
|
|
).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "when user is not an admin" do
|
|
fab!(:regular_user, :user)
|
|
|
|
it "does not show the banner" do
|
|
sign_in(regular_user)
|
|
visit("/")
|
|
|
|
expect(banner).to be_not_visible
|
|
end
|
|
end
|
|
|
|
describe "when setting is disabled" do
|
|
before { SiteSetting.enable_site_owner_onboarding = false }
|
|
|
|
it "does not show the banner" do
|
|
visit("/")
|
|
|
|
expect(banner).to be_not_visible
|
|
end
|
|
end
|
|
end
|