mirror of
https://github.com/discourse/discourse.git
synced 2026-08-10 23:59:31 +08:00
8ba7a6448bExcluding small actions from a topic's counters (#40481) also excluded them from `highest_post_number` / `highest_staff_post_number`, which are the ceiling that `topic_users.last_read_post_number` is clamped to. As a result, a topic whose last post is a small action (a close, pin, archive, etc. notice) could never be read past that notice: the "last visit" line stayed above it on every visit and the topic never read as fully caught up (https://meta.discourse.org/t/-/404058). The root cause is that `highest_post_number` quietly served two roles — the highest post worth *notifying* about, and the highest post a user can *see* (the read-position ceiling). Those were only ever the same value because small actions used to count toward both. Dropping them from the columns is correct for the first role but wrong for the second: small actions are visible to everyone and occupy real stream positions that get read. This keeps the columns meaning "highest notify-worthy post" — so `/unread`, the unread badge, and watched notifications stay correct and cheap — and derives "highest post in the visible stream" wherever a read position is written. That value includes small actions (and whispers only for whisperers) and lives in `Topic.highest_post_number_in_stream`; every read-tracking path now goes through it: recording timings, the `last_read` clamp, `reset_highest`, `dismiss_posts`, the close/auto-close `pretend_read` target, nested-topic catch-up, and the post-merge caught-up detection. Because `last_read_post_number` can now legitimately exceed the notify counter, a few checks that assumed the two were equal became `>=` (the private-message read indicator, the topic model's `visited` / `canClearPin`, and the client-side tracking state). Finally, `process_timings` computes the visible-stream ceiling once and threads it into `update_last_read`, so the clamp no longer re-derives it and the hottest read path stays a single index-backed `MAX(post_number)`. |
||
|---|---|---|
| .. | ||
| admin | ||
| api | ||
| examples | ||
| about_controller_spec.rb | ||
| access_control_lists_controller_spec.rb | ||
| anonymous_actions_controller_spec.rb | ||
| application_controller_spec.rb | ||
| associate_accounts_controller_spec.rb | ||
| badges_controller_spec.rb | ||
| bookmarks_controller_spec.rb | ||
| calendar_subscriptions_controller_spec.rb | ||
| categories_controller_spec.rb | ||
| clicks_controller_spec.rb | ||
| composer_controller_spec.rb | ||
| composer_messages_controller_spec.rb | ||
| crawler_hreflang_spec.rb | ||
| default_headers_spec.rb | ||
| dev_mode_controller_spec.rb | ||
| directory_columns_controller_spec.rb | ||
| directory_items_controller_spec.rb | ||
| discourse_id_controller_spec.rb | ||
| do_not_disturb_controller_spec.rb | ||
| drafts_controller_spec.rb | ||
| edit_directory_columns_controller_spec.rb | ||
| email_controller_spec.rb | ||
| embed_controller_spec.rb | ||
| emojis_controller_spec.rb | ||
| exceptions_controller_spec.rb | ||
| export_csv_controller_spec.rb | ||
| extra_locales_controller_spec.rb | ||
| finish_installation_controller_spec.rb | ||
| form_templates_controller_spec.rb | ||
| forums_controller_spec.rb | ||
| gifs_controller_spec.rb | ||
| groups_controller_spec.rb | ||
| hashtags_controller_spec.rb | ||
| highlightjs_controller_spec.rb | ||
| home_page_controller_spec.rb | ||
| inline_onebox_controller_spec.rb | ||
| invites_controller_spec.rb | ||
| list_controller_spec.rb | ||
| metadata_controller_spec.rb | ||
| nested_topics_controller_spec.rb | ||
| net_http_header_spec.rb | ||
| net_http_timeout_spec.rb | ||
| noscript_escape_spec.rb | ||
| notifications_controller_spec.rb | ||
| offline_controller_spec.rb | ||
| omniauth_callbacks_controller_spec.rb | ||
| onebox_controller_spec.rb | ||
| permalinks_controller_spec.rb | ||
| post_action_users_controller_spec.rb | ||
| post_actions_controller_spec.rb | ||
| post_localizations_controller_spec.rb | ||
| post_readers_controller_spec.rb | ||
| posts_controller_spec.rb | ||
| presence_controller_spec.rb | ||
| published_pages_controller_spec.rb | ||
| push_notification_controller_spec.rb | ||
| qunit_controller_spec.rb | ||
| reviewable_claimed_topics_controller_spec.rb | ||
| reviewable_notes_controller_spec.rb | ||
| reviewables_controller_spec.rb | ||
| robots_txt_controller_spec.rb | ||
| safe_mode_controller_spec.rb | ||
| search_controller_spec.rb | ||
| session_controller_spec.rb | ||
| sidebar_sections_controller_spec.rb | ||
| similar_topics_controller_spec.rb | ||
| site_controller_spec.rb | ||
| sitemap_controller_spec.rb | ||
| slugs_controller_spec.rb | ||
| static_controller_spec.rb | ||
| steps_controller_spec.rb | ||
| stylesheets_controller_spec.rb | ||
| svg_sprite_controller_spec.rb | ||
| tag_groups_controller_spec.rb | ||
| tag_localizations_controller_spec.rb | ||
| tags_controller_spec.rb | ||
| theme_import_map_spec.rb | ||
| theme_javascripts_controller_spec.rb | ||
| topic_localizations_controller_spec.rb | ||
| topic_view_stats_controller_spec.rb | ||
| topics_controller_spec.rb | ||
| uploads_controller_multisite_spec.rb | ||
| uploads_controller_spec.rb | ||
| user_actions_controller_spec.rb | ||
| user_api_key_clients_controller_spec.rb | ||
| user_api_keys_controller_spec.rb | ||
| user_avatars_controller_spec.rb | ||
| user_badges_controller_spec.rb | ||
| user_status_controller_spec.rb | ||
| users_controller_spec.rb | ||
| users_email_controller_spec.rb | ||
| webhooks_controller_spec.rb | ||
| wizard_controller_spec.rb | ||
