mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 07:23:30 +08:00
6dfcbb6282Ruby 3.4 shipped support for happy eyeballs in `Socket.tcp` and `TCPSocket`. However, our `FinalDestination::HTTP` wrapper was performing a DNS lookup and passing IP addresses one at a time when opening the socket. That meant that we didn't benefit from the new Ruby feature in most Discourse features. This commit factors the strategy. Now, `FinalDestination::HTTP` encodes the DNS result and passes it to the underlying implementation as a fake hostname string. A patch to `Addrinfo` detects this fake hostname and returns the given IPs instead of performing its own lookup. For this Addrinfo patch to work, we also had to patch `TCPSocket` so that it uses the ruby-based `Socket.tcp` rather than its native C socket-opening code. The result is that we now get the benefit of the native Ruby 'Happy Eyeballs' support for concurrent ipv4 and ipv6 connections. All this patching of low-level ruby classes is not ideal, but there is no native way to control name resolution in `Net::HTTP` or its dependencies. |
||
|---|---|---|
| .. | ||
| fast_image_spec.rb | ||
| propshaft_patches_spec.rb | ||
| rspec_mocks_from_described_class_spec.rb | ||
| safe_buffer_spec.rb | ||
| schema_migration_details_spec.rb | ||
| translate_accelerator_spec.rb | ||
| web_push_spec.rb | ||
