mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
Admins can now search for multiple users at once in `/admin/users/list` by separating usernames or emails with commas or whitespace — useful for support workflows where a list of users needs to be checked in one go (e.g. pasted from a spreadsheet; spaces work because usernames and emails can never contain them). The search is also shareable via URL: typing keeps the address bar in sync with a `filter` query param (`/admin/users/list/active?filter=sam,bob@example.com`), and visiting such a URL prefills the search box and filters the list. The old `username` query param keeps working as a read-only legacy fallback — it was a misleading name, since searches also match emails. ## Demo: https://github.com/user-attachments/assets/c85e4f30-3c06-493b-9fed-bb2057209c5d
360 lines
12 KiB
Ruby
Vendored
360 lines
12 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe AdminUserIndexQuery do
|
|
def real_users(query)
|
|
query.find_users_query.where("users.id > 0")
|
|
end
|
|
|
|
describe "sql order" do
|
|
it "has default" do
|
|
query = ::AdminUserIndexQuery.new({})
|
|
expect(query.find_users_query.to_sql).to match("created_at DESC")
|
|
end
|
|
|
|
it "has active order" do
|
|
query = ::AdminUserIndexQuery.new(query: "active")
|
|
expect(query.find_users_query.to_sql).to match("last_seen_at")
|
|
end
|
|
|
|
it "can't be injected" do
|
|
query = ::AdminUserIndexQuery.new(order: "wat, no")
|
|
expect(query.find_users_query.to_sql).not_to match("wat, no")
|
|
end
|
|
|
|
it "allows custom ordering" do
|
|
query = ::AdminUserIndexQuery.new(order: "trust_level")
|
|
expect(query.find_users_query.to_sql).to match("trust_level DESC")
|
|
end
|
|
|
|
it "allows custom ordering asc" do
|
|
query = ::AdminUserIndexQuery.new(order: "trust_level", asc: true)
|
|
expect(query.find_users_query.to_sql).to match("trust_level ASC")
|
|
end
|
|
|
|
it "allows custom ordering for stats with default direction" do
|
|
query = ::AdminUserIndexQuery.new(order: "topics_viewed")
|
|
expect(query.find_users_query.to_sql).to match("topics_entered DESC")
|
|
end
|
|
|
|
it "allows custom ordering and direction for stats" do
|
|
query = ::AdminUserIndexQuery.new(order: "topics_viewed", asc: true)
|
|
expect(query.find_users_query.to_sql).to match("topics_entered ASC")
|
|
end
|
|
end
|
|
|
|
describe "pagination" do
|
|
it "defaults to the first page" do
|
|
query = ::AdminUserIndexQuery.new({})
|
|
expect(query.find_users.to_sql).to match("OFFSET 0")
|
|
end
|
|
|
|
it "offsets by 100 by default for page 2" do
|
|
query = ::AdminUserIndexQuery.new(page: "2")
|
|
expect(query.find_users.to_sql).to match("OFFSET 100")
|
|
end
|
|
|
|
it "offsets by limit for page 2" do
|
|
query = ::AdminUserIndexQuery.new(page: "2")
|
|
expect(query.find_users(10).to_sql).to match("OFFSET 10")
|
|
end
|
|
|
|
it "ignores negative pages" do
|
|
query = ::AdminUserIndexQuery.new(page: "-2")
|
|
expect(query.find_users.to_sql).to match("OFFSET 0")
|
|
end
|
|
end
|
|
|
|
describe "no users with trust level" do
|
|
TrustLevel.levels.each do |key, value|
|
|
it "#{key} returns no records" do
|
|
query = ::AdminUserIndexQuery.new(query: key.to_s)
|
|
expect(real_users(query)).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "users with trust level" do
|
|
TrustLevel.levels.each do |key, value|
|
|
it "finds user with trust #{key}" do
|
|
user = Fabricate(:user, trust_level: value)
|
|
|
|
next if !TrustLevel.valid?(value + 1)
|
|
Fabricate(:user, trust_level: value + 1)
|
|
|
|
query = ::AdminUserIndexQuery.new(query: key.to_s)
|
|
expect(real_users(query).to_a).to eq([user])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "with a pending user" do
|
|
fab!(:user) { Fabricate(:user, active: true, approved: false) }
|
|
fab!(:inactive_user) { Fabricate(:user, approved: false, active: false) }
|
|
|
|
it "finds the unapproved user" do
|
|
query = ::AdminUserIndexQuery.new(query: "pending")
|
|
expect(query.find_users).to include(user)
|
|
expect(query.find_users).not_to include(inactive_user)
|
|
end
|
|
|
|
context "with a suspended pending user" do
|
|
fab!(:suspended_user) do
|
|
Fabricate(
|
|
:user,
|
|
approved: false,
|
|
suspended_at: 1.hour.ago,
|
|
suspended_till: 20.years.from_now,
|
|
)
|
|
end
|
|
it "doesn't return the suspended user" do
|
|
query = ::AdminUserIndexQuery.new(query: "pending")
|
|
expect(query.find_users).not_to include(suspended_user)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "correct order with nil values" do
|
|
before(:each) { Fabricate(:user, email: "test2@example.com", last_emailed_at: 1.hour.ago) }
|
|
|
|
it "shows nil values first with asc" do
|
|
users = ::AdminUserIndexQuery.new(order: "last_emailed", asc: true).find_users
|
|
|
|
expect(users.where("users.id > -2").count).to eq(2)
|
|
expect(users.where("users.id > -2").order("users.id asc").first.username).to eq("system")
|
|
expect(users.first.last_emailed_at).to eq(nil)
|
|
end
|
|
|
|
it "shows nil values last with desc" do
|
|
users = ::AdminUserIndexQuery.new(order: "last_emailed").find_users
|
|
|
|
expect(users.where("users.id > -2").count).to eq(2)
|
|
expect(users.first.last_emailed_at).to_not eq(nil)
|
|
end
|
|
end
|
|
|
|
describe "with an admin user" do
|
|
fab!(:user) { Fabricate(:user, admin: true) }
|
|
fab!(:user2) { Fabricate(:user, admin: false) }
|
|
|
|
it "finds the admin" do
|
|
query = ::AdminUserIndexQuery.new(query: "admins")
|
|
expect(real_users(query)).to eq([user])
|
|
end
|
|
end
|
|
|
|
describe "with a moderator" do
|
|
fab!(:user) { Fabricate(:user, moderator: true) }
|
|
fab!(:user2) { Fabricate(:user, moderator: false) }
|
|
|
|
it "finds the moderator" do
|
|
query = ::AdminUserIndexQuery.new(query: "moderators")
|
|
expect(real_users(query)).to eq([user])
|
|
end
|
|
end
|
|
|
|
describe "with a silenced user" do
|
|
fab!(:user) { Fabricate(:user, silenced_till: 1.year.from_now) }
|
|
fab!(:user2, :user)
|
|
|
|
it "finds the silenced user" do
|
|
query = ::AdminUserIndexQuery.new(query: "silenced")
|
|
expect(real_users(query)).to eq([user])
|
|
end
|
|
end
|
|
|
|
describe "sorting by a penalty reason" do
|
|
fab!(:user_a) { Fabricate(:user, suspended_till: 1.year.from_now, suspended_at: Time.zone.now) }
|
|
fab!(:user_z) { Fabricate(:user, suspended_till: 1.year.from_now, suspended_at: Time.zone.now) }
|
|
|
|
before do
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:suspend_user],
|
|
target_user_id: user_a.id,
|
|
acting_user_id: Discourse.system_user.id,
|
|
details: "aaa reason",
|
|
)
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:suspend_user],
|
|
target_user_id: user_z.id,
|
|
acting_user_id: Discourse.system_user.id,
|
|
details: "zzz reason",
|
|
)
|
|
end
|
|
|
|
it "orders by the suspend reason (joining only when sorting by it)" do
|
|
query = ::AdminUserIndexQuery.new(query: "suspended", order: "suspend_reason", asc: "true")
|
|
expect(real_users(query).map(&:id)).to eq([user_a.id, user_z.id])
|
|
end
|
|
end
|
|
|
|
describe "with a staged user" do
|
|
fab!(:user) { Fabricate(:user, staged: true) }
|
|
fab!(:user2) { Fabricate(:user, staged: false) }
|
|
|
|
it "finds the staged user" do
|
|
query = ::AdminUserIndexQuery.new(query: "staged")
|
|
expect(real_users(query)).to eq([user])
|
|
end
|
|
end
|
|
|
|
describe "with the activation filter" do
|
|
fab!(:activated_user) { Fabricate(:user, active: true) }
|
|
fab!(:not_activated_user) { Fabricate(:user, active: false) }
|
|
|
|
it "finds only not activated users" do
|
|
query = ::AdminUserIndexQuery.new(query: "new", activation: "not_activated")
|
|
expect(real_users(query)).to contain_exactly(not_activated_user)
|
|
end
|
|
|
|
it "finds only activated users" do
|
|
query = ::AdminUserIndexQuery.new(query: "new", activation: "activated")
|
|
expect(real_users(query)).to contain_exactly(activated_user)
|
|
end
|
|
|
|
it "finds all users when no activation filter is provided" do
|
|
query = ::AdminUserIndexQuery.new(query: "new")
|
|
expect(real_users(query)).to contain_exactly(activated_user, not_activated_user)
|
|
end
|
|
end
|
|
|
|
describe "filtering" do
|
|
context "with exact email bypass" do
|
|
it "can correctly bypass expensive ilike query" do
|
|
user = Fabricate(:user, email: "sam@Sam.com")
|
|
|
|
query = AdminUserIndexQuery.new(filter: "Sam@sam.com").find_users_query
|
|
expect(query.count).to eq(1)
|
|
expect(query.first.id).to eq(user.id)
|
|
|
|
expect(query.to_sql.downcase).not_to include("ilike")
|
|
end
|
|
|
|
it "can correctly bypass expensive ilike query" do
|
|
user = Fabricate(:user, email: "sam2@Sam.com")
|
|
|
|
query = AdminUserIndexQuery.new(email: "Sam@sam.com").find_users_query
|
|
expect(query.count).to eq(0)
|
|
expect(query.to_sql.downcase).not_to include("ilike")
|
|
|
|
query = AdminUserIndexQuery.new(email: "Sam2@sam.com").find_users_query
|
|
expect(query.first.id).to eq(user.id)
|
|
expect(query.count).to eq(1)
|
|
expect(query.to_sql.downcase).not_to include("ilike")
|
|
end
|
|
end
|
|
|
|
context "with email fragment" do
|
|
before(:each) { Fabricate(:user, email: "test1@example.com") }
|
|
|
|
it "matches the email" do
|
|
query = ::AdminUserIndexQuery.new(filter: " est1")
|
|
expect(query.find_users.count()).to eq(1)
|
|
end
|
|
|
|
it "matches the email using any case" do
|
|
query = ::AdminUserIndexQuery.new(filter: "Test1\t")
|
|
expect(query.find_users.count()).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "with username fragment" do
|
|
before(:each) { Fabricate(:user, username: "test_user_1") }
|
|
|
|
it "matches the username" do
|
|
query = ::AdminUserIndexQuery.new(filter: "user\n")
|
|
expect(query.find_users.count).to eq(1)
|
|
end
|
|
|
|
it "matches the username using any case" do
|
|
query = ::AdminUserIndexQuery.new(filter: "\r\nUser")
|
|
expect(query.find_users.count).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "with ip address fragment" do
|
|
fab!(:user) { Fabricate(:user, ip_address: "117.207.94.9") }
|
|
|
|
it "matches the ip address" do
|
|
query =
|
|
::AdminUserIndexQuery.new(filter: " 117.207.94.9 ", guardian: Fabricate(:admin).guardian)
|
|
expect(query.find_users.count()).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "with multiple terms" do
|
|
fab!(:user_one) { Fabricate(:user, username: "bulk_user_1", email: "first@example.com") }
|
|
fab!(:user_two) { Fabricate(:user, username: "bulk_user_2", email: "second@example.com") }
|
|
|
|
it "matches usernames separated by commas" do
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1,bulk_user_2")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "matches usernames separated by whitespace" do
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1 bulk_user_2")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1\nbulk_user_2")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "matches a mix of usernames and emails" do
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1, second@example.com")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "matches a list of emails" do
|
|
query = ::AdminUserIndexQuery.new(filter: "first@example.com,second@example.com")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
|
|
query = ::AdminUserIndexQuery.new(filter: "first@example.com second@example.com")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "matches secondary emails exactly" do
|
|
Fabricate(:secondary_email, user: user_two, email: "extra@elsewhere.com")
|
|
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1,extra@elsewhere.com")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "ignores blank tokens" do
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1, ,, bulk_user_2,")
|
|
expect(query.find_users).to contain_exactly(user_one, user_two)
|
|
end
|
|
|
|
it "treats like and regex metacharacters literally" do
|
|
query = ::AdminUserIndexQuery.new(filter: "bulk_user_1,foo(")
|
|
expect(query.find_users).to contain_exactly(user_one)
|
|
|
|
query = ::AdminUserIndexQuery.new(filter: "a|b,zzz%")
|
|
expect(query.find_users).to be_empty
|
|
end
|
|
|
|
it "still uses the exact email bypass for a single term with a trailing comma" do
|
|
query = ::AdminUserIndexQuery.new(filter: "first@example.com,").find_users_query
|
|
expect(query.to_sql.downcase).not_to include("ilike")
|
|
expect(query).to contain_exactly(user_one)
|
|
end
|
|
|
|
it "does not search by ip address when multiple terms are given" do
|
|
Fabricate(:user, ip_address: "117.207.94.9")
|
|
|
|
query =
|
|
::AdminUserIndexQuery.new(
|
|
filter: "117.207.94.9,117.207.94.10",
|
|
guardian: Fabricate(:admin).guardian,
|
|
)
|
|
expect(query.find_users).to be_empty
|
|
end
|
|
|
|
it "raises when there are too many terms" do
|
|
filter = (0..AdminUserIndexQuery::MAX_FILTER_TERMS).map { |i| "user#{i}" }.join(",")
|
|
|
|
expect { ::AdminUserIndexQuery.new(filter: filter).find_users }.to raise_error(
|
|
Discourse::InvalidParameters,
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|