mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
Previously, bulk tag, category, and conversion changes skipped creating a post revision, so each change silently folded into the topic's most recent revision — attributing it to that revision's author and date rather than to whoever ran the bulk action. This was reported for the new bulk "Manage tags" flow on [meta](https://meta.discourse.org/t/better-bulk-tag-management/402693). This routes every bulk metadata change through `PostRevisor` so it always records its own revision, attributed to the acting user. Along the way it also: - Unifies the silent/notify handling across bulk actions: the bulk "Manage tags" modal gains a "Notify users" checkbox, and the bulk convert modal's checkbox now actually toggles notifications instead of doing nothing. - Records topic conversions as a staff-only (hidden) revision so a former private message is not disclosed in public edit history. - Stops a different user's hidden-tag change from folding into an earlier author's revision. - Removes the now-redundant `create_revision_on_bulk_topic_moves` site setting, whose disabled state reintroduced the bug and whose enabled state was already the default.
174 lines
4.8 KiB
Ruby
Vendored
174 lines
4.8 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
class TopicConverter
|
|
attr_reader :topic
|
|
|
|
def initialize(topic, user, silent: false)
|
|
@topic = topic
|
|
@user = user
|
|
@silent = silent
|
|
end
|
|
|
|
def convert_to_public_topic(category_id = nil)
|
|
Topic.transaction do
|
|
category_id ||=
|
|
SiteSetting.uncategorized_category_id if SiteSetting.allow_uncategorized_topics
|
|
|
|
@category = Category.find_by(id: category_id) if category_id
|
|
@category ||=
|
|
Category
|
|
.where(read_restricted: false)
|
|
.where.not(id: SiteSetting.uncategorized_category_id)
|
|
.first
|
|
|
|
PostRevisor.new(@topic.first_post, @topic).revise!(
|
|
@user,
|
|
{ category_id: @category.id, archetype: Archetype.default },
|
|
revise_opts,
|
|
)
|
|
|
|
raise ActiveRecord::Rollback if !@topic.valid?
|
|
|
|
update_user_stats
|
|
update_post_uploads_secure_status
|
|
add_small_action("public_topic") unless @silent
|
|
Tag.update_counters(@topic.tags, { public_topic_count: 1 }) if !@category.read_restricted
|
|
|
|
Jobs.enqueue(:topic_action_converter, topic_id: @topic.id)
|
|
Jobs.enqueue(:delete_inaccessible_notifications, topic_id: @topic.id)
|
|
|
|
watch_topic(@topic) unless @silent
|
|
end
|
|
|
|
@topic
|
|
end
|
|
|
|
def convert_to_private_message
|
|
if exceeds_recipient_cap?
|
|
@topic.errors.add(
|
|
:base,
|
|
I18n.t(
|
|
"topic_converter.too_many_recipients",
|
|
max: SiteSetting.max_allowed_message_recipients,
|
|
),
|
|
)
|
|
return @topic
|
|
end
|
|
|
|
Topic.transaction do
|
|
was_public = !@topic.category.read_restricted
|
|
@topic.update_category_topic_count_by(-1) if @topic.visible
|
|
|
|
PostRevisor.new(@topic.first_post, @topic).revise!(
|
|
@user,
|
|
{ category_id: nil, archetype: Archetype.private_message },
|
|
revise_opts,
|
|
)
|
|
|
|
raise ActiveRecord::Rollback if !@topic.valid?
|
|
|
|
add_allowed_users
|
|
update_post_uploads_secure_status
|
|
add_small_action("private_topic") unless @silent
|
|
Tag.update_counters(@topic.tags, { public_topic_count: -1 }) if was_public
|
|
UserProfile.remove_featured_topic_from_all_profiles(@topic)
|
|
|
|
Jobs.enqueue(:topic_action_converter, topic_id: @topic.id)
|
|
Jobs.enqueue(:delete_inaccessible_notifications, topic_id: @topic.id)
|
|
|
|
watch_topic(@topic) unless @silent
|
|
end
|
|
|
|
@topic
|
|
end
|
|
|
|
private
|
|
|
|
def revise_opts
|
|
{ bypass_bump: @silent, silent: @silent, hidden: true }
|
|
end
|
|
|
|
def posters
|
|
@posters ||=
|
|
@topic
|
|
.posts
|
|
.where.not(post_type: [Post.types[:small_action], Post.types[:whisper]])
|
|
.distinct
|
|
.pluck(:user_id)
|
|
end
|
|
|
|
def increment_users_post_count
|
|
update_users_post_count(:increment)
|
|
end
|
|
|
|
def decrement_users_post_count
|
|
update_users_post_count(:decrement)
|
|
end
|
|
|
|
def update_users_post_count(action)
|
|
operation = action == :increment ? "+" : "-"
|
|
|
|
# NOTE that DirectoryItem.refresh will overwrite this by counting UserAction records.
|
|
#
|
|
# Changes user_stats (post_count) by the number of posts in the topic.
|
|
# First post, hidden posts and non-regular posts are ignored.
|
|
DB.exec <<~SQL
|
|
UPDATE user_stats
|
|
SET post_count = post_count #{operation} X.count
|
|
FROM (
|
|
SELECT
|
|
us.user_id,
|
|
COUNT(*) AS count
|
|
FROM user_stats us
|
|
INNER JOIN posts ON posts.topic_id = #{@topic.id.to_i} AND posts.user_id = us.user_id
|
|
WHERE posts.post_number > 1
|
|
AND NOT posts.hidden
|
|
AND posts.post_type = #{Post.types[:regular].to_i}
|
|
GROUP BY us.user_id
|
|
) X
|
|
WHERE X.user_id = user_stats.user_id
|
|
SQL
|
|
end
|
|
|
|
def update_user_stats
|
|
increment_users_post_count
|
|
UserStatCountUpdater.increment!(@topic.first_post)
|
|
end
|
|
|
|
def add_allowed_users
|
|
decrement_users_post_count
|
|
UserStatCountUpdater.decrement!(@topic.first_post)
|
|
|
|
existing_allowed_users = @topic.topic_allowed_users.pluck(:user_id)
|
|
users_to_allow = posters << @user.id
|
|
|
|
(users_to_allow - existing_allowed_users).uniq.each do |user_id|
|
|
@topic.topic_allowed_users.build(user_id: user_id)
|
|
end
|
|
|
|
@topic.save!
|
|
end
|
|
|
|
def exceeds_recipient_cap?
|
|
allowed_users = @topic.topic_allowed_users.pluck(:user_id)
|
|
total_recipients = (posters | allowed_users | [@user.id]).size
|
|
total_recipients > SiteSetting.max_allowed_message_recipients
|
|
end
|
|
|
|
def watch_topic(topic)
|
|
@topic.notifier.watch_topic!(topic.user_id)
|
|
|
|
@topic.reload.topic_allowed_users.each do |tau|
|
|
next if tau.user_id < 0 || tau.user_id == topic.user_id
|
|
topic.notifier.watch!(tau.user_id)
|
|
end
|
|
end
|
|
|
|
def update_post_uploads_secure_status
|
|
DB.after_commit { Jobs.enqueue(:update_topic_upload_security, topic_id: @topic.id) }
|
|
end
|
|
|
|
def add_small_action(action_code)
|
|
DB.after_commit { @topic.add_small_action(@user, action_code) }
|
|
end
|
|
end
|