mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 09:05:23 +08:00
beba9d0c11When an edit adds media that `skip_review_media_groups` requires staff to approve, queueing a reviewable is not enough. At creation the check holds the whole post back until it is approved, but on the edit path the media stayed publicly visible until a moderator got to the queue, defeating the point of a review meant to happen before publication. The post is now hidden — and the topic unlisted when it is the first post — under a dedicated hidden reason while the review is pending. Approving through the existing approve-and-unhide action restores both. The author is told what happened in a PM, and every placeholder (app, crawler view, RSS) explains the post is awaiting media review instead of claiming it was flagged by the community. Reusing the hidden flag means the flag system could unhide the post while the media review was still pending: a moderator disagreeing with an unrelated flag, a user withdrawing one, or the author editing a flag-hidden post would all have published the unreviewed media. Unhiding now refuses while a media review is pending unless it is forced, which only the review's approval and a staff member explicitly unhiding the post do. Since this hide is not a flag: - the flag cooldown no longer locks the author out of editing — editing a media-hidden post never unhides it, so there is nothing to game; - hiding no longer overwrites the visibility reason of a topic that was already unlisted, so approving the media cannot silently relist a topic a moderator deliberately unlisted (which also fixes the same long-standing clobber on the flag path); - the system message options only include a flag reason when there is an actual flag, since interpolating `flag_reasons.` with no type stuffed the entire translation subtree into the job arguments. Hiding is only worth doing if the content is actually hidden, so the topic's og:image and the RSS channel description — which rendered the first post's raw — no longer advertise the content of a hidden first post. System-driven revisions (`skip_validations`) are exempt from the check, matching creation where programmatic post creation never goes through the new-post checks; refreshing a topic embed should not unlist a blog topic. |
||
|---|---|---|
| .. | ||
| db | ||
| fabricators | ||
| fixtures | ||
| generator | ||
| helpers | ||
| import_export | ||
| initializers | ||
| integration | ||
| integrity | ||
| jobs | ||
| lib | ||
| mailers | ||
| migrations | ||
| models | ||
| multisite | ||
| queries/reports | ||
| requests | ||
| script | ||
| serializers | ||
| services | ||
| support | ||
| system | ||
| tasks | ||
| views | ||
| rails_helper.rb | ||
| regenerate_swagger_docs | ||
| swagger_helper.rb | ||
