mirror of
https://github.com/discourse/discourse.git
synced 2026-08-09 21:45:25 +08:00
ce2767cf38Chat channel oneboxes have been rendering with no icon next to the channel title since #20744. That PR changed the mustache templates to emit `<svg><use href="#d-chat"></use></svg>` and registered a JS-side `replaceIcon("d-chat", "comment")` to compensate. The replacement only runs through `iconHTML()` / `{{icon}}` at render time though — the mustache markup is cooked into the post HTML server-side, so the JS swap never touches it. `d-chat` has never been part of the SVG sprite, which means the browser cannot resolve `#d-chat` and the badge renders empty. This commit pre-renders the channel badge in `Chat::OneboxHandler` and passes it to the templates as a single HTML blob: * When the channel has an emoji, it is rendered via `Emoji.codes_to_img`. * Otherwise we fall back to the chat bubble (`#comment`, which is in the sprite) tinted with the channel's category color. The fix covers all three onebox templates (channel, message, thread). A post-deploy migration flips `baked_version` to 0 on every post whose cooked HTML contains `chat-onebox`, so the recurring `Post.rebake_old` job picks them up and rebakes them in the background with the fixed templates. Ref - t/183234
22 lines
806 B
Text
Vendored
22 lines
806 B
Text
Vendored
<aside class="onebox chat-onebox">
|
|
<article class="onebox-body chat-onebox-body">
|
|
<h3 class="chat-onebox-title">
|
|
<a href="/chat/c/-/{{channel_id}}">
|
|
{{{channel_badge}}}
|
|
<span class="clear-badge">{{channel_name}}</span>
|
|
</a>
|
|
</h3>
|
|
{{#description}}
|
|
<div class="chat-onebox-description">{{description}}</div>
|
|
{{/description}}
|
|
<div class="chat-onebox-members-count">{{user_count_str}}</div>
|
|
<div class="chat-onebox-members">
|
|
{{#users}}
|
|
<a class="trigger-user-card" data-user-card="{{username}}" aria-hidden="true" tabindex="-1">
|
|
<img loading="lazy" alt="{{username}}" width="30" height="30" src="{{avatar_url}}" class="avatar">
|
|
</a>
|
|
{{/users}}
|
|
{{remaining_user_count_str}}
|
|
</div>
|
|
</article>
|
|
</aside>
|
