mirror of
https://github.com/discourse/discourse.git
synced 2026-08-09 21:45:25 +08:00
6df9b0b357RSpec setup becomes harder to follow at either extreme: trivial fixture wrappers hide lifecycle and intent, while forcing every named operation inline repeats low-level protocol and configuration details. This change documents and applies a test-setup hierarchy: - use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according to lifecycle and role; - use a small example-group method when parameterized behavior gives one spec useful vocabulary; - move helpers into auto-loaded `spec/support` only when they are shared across spec files; - use fabricators and page objects for the data shapes and system-test interfaces they own. Core and plugin support files are loaded centrally by `rails_helper`, so plugin-specific support loaders are unnecessary. The migration specs encountered during the sweep are removed according to repository policy; production migrations are unchanged.
32 lines
888 B
Ruby
Vendored
32 lines
888 B
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe ProblemCheck::UnreachableThemes do
|
|
subject(:check) { described_class.new }
|
|
|
|
describe ".call" do
|
|
let(:remote) do
|
|
RemoteTheme.create!(
|
|
remote_url: "https://github.com/org/testtheme",
|
|
last_error_text: last_error,
|
|
)
|
|
end
|
|
|
|
let!(:theme) { Fabricate(:theme, id: 50, remote_theme: remote, name: "Test Theme") }
|
|
|
|
context "when theme is unreachable" do
|
|
let(:last_error) { "Can't reach. Too short." }
|
|
|
|
it do
|
|
expect(check).to have_a_problem.with_priority("low").with_message(
|
|
'We were unable to check for updates on the following themes:<ul><li><a href="/admin/customize/themes/50">Test Theme</a></li></ul>',
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when theme is reachable" do
|
|
let(:last_error) { nil }
|
|
|
|
it { expect(check).to be_chill_about_it }
|
|
end
|
|
end
|
|
end
|
