mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-15 03:39:43 +08:00
This commit introduces deprecation warnings for accessing Site.mobileView or Site.desktopView during application initialization to prevent layout-related errors and improve code reliability. The changes include: * Added deprecation warnings for Site.mobileView and Site.desktopView access during the initialization phase. * Updated multiple plugins and components to avoid these deprecated calls during startup. * Refactored initialization logic across discourse-ai, discourse-chat, discourse-calendar, discourse-reactions, discourse-assign, discourse-subscriptions, and discourse-user-notes plugins * Improved error prevention by discouraging early access to view-dependent properties before the application is fully initialized * Enhanced code maintainability by establishing clearer boundaries between initialization and runtime phases This deprecation helps prevent subtle bugs that can occur when components try to determine the view type before the application context is properly established, leading to more robust plugin initialization patterns.
154 lines
4.9 KiB
JavaScript
154 lines
4.9 KiB
JavaScript
import { click, visit } from "@ember/test-helpers";
|
|
import { skip } from "qunit";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
acceptance("Discourse Chat - Chat live pane collapse", function (needs) {
|
|
needs.user({
|
|
username: "eviltrout",
|
|
id: 1,
|
|
can_chat: true,
|
|
has_chat_enabled: true,
|
|
});
|
|
|
|
needs.settings({
|
|
chat_enabled: true,
|
|
enable_emoji: true,
|
|
});
|
|
|
|
needs.pretender((server, helper) => {
|
|
server.get("/chat/:chatChannelId/messages.json", () =>
|
|
helper.response({
|
|
meta: {
|
|
can_chat: true,
|
|
user_silenced: false,
|
|
},
|
|
chat_messages: [
|
|
{
|
|
id: 1,
|
|
message: "https://www.youtube.com/watch?v=aOWkVdU4NH0",
|
|
cooked:
|
|
'<div class="youtube-onebox lazy-video-container" data-video-id="aOWkVdU4NH0" data-video-title="Picnic with my cat (shaved ice & lemonade)" data-provider-name="youtube"> <a href="https://www.youtube.com/watch?v=aOWkVdU4NH0" target="_blank" rel="nofollow ugc noopener"> <img class="youtube-thumbnail" src="https://img.youtube.com/vi/aOWkVdU4NH0/maxresdefault.jpg" title="Picnic with my cat (shaved ice & lemonade)"> </a> </div>',
|
|
excerpt:
|
|
'<a href="https://www.youtube.com/watch?v=aOWkVdU4NH0">[Picnic with my cat (shaved ice & lemonade…</a>',
|
|
created_at: "2021-07-20T08:14:16.950Z",
|
|
flag_count: 0,
|
|
user: {
|
|
avatar_template:
|
|
"/letter_avatar_proxy/v4/letter/t/a9a28c/{size}.png",
|
|
id: 1,
|
|
name: "Tomtom",
|
|
username: "tomtom",
|
|
},
|
|
},
|
|
{
|
|
id: 2,
|
|
message: "",
|
|
cooked: "",
|
|
excerpt: "",
|
|
uploads: [
|
|
{
|
|
id: 4,
|
|
url: "/images/avatar.png",
|
|
original_filename: "tomtom.jpeg",
|
|
filesize: 93815,
|
|
width: 480,
|
|
height: 640,
|
|
thumbnail_width: 375,
|
|
thumbnail_height: 500,
|
|
extension: "jpeg",
|
|
retain_hours: null,
|
|
human_filesize: "91.6 KB",
|
|
},
|
|
],
|
|
user: {
|
|
avatar_template:
|
|
"/letter_avatar_proxy/v4/letter/t/a9a28c/{size}.png",
|
|
id: 1,
|
|
name: "Tomtom",
|
|
username: "tomtom",
|
|
},
|
|
},
|
|
],
|
|
})
|
|
);
|
|
|
|
server.get("/chat/chat_channels.json", () =>
|
|
helper.response({
|
|
public_channels: [],
|
|
direct_message_channels: [],
|
|
message_bus_last_ids: {
|
|
channel_metadata: 0,
|
|
channel_edits: 0,
|
|
channel_status: 0,
|
|
new_channel: 0,
|
|
user_tracking_state: 0,
|
|
},
|
|
})
|
|
);
|
|
|
|
server.get("/chat/chat_channels/:chatChannelId", () =>
|
|
helper.response({ id: 1, title: "something" })
|
|
);
|
|
|
|
server.post("/uploads/lookup-urls", () =>
|
|
helper.response([
|
|
200,
|
|
{ "Content-Type": "application/json" },
|
|
[
|
|
{
|
|
url: "/images/avatar.png",
|
|
},
|
|
],
|
|
])
|
|
);
|
|
});
|
|
|
|
skip("can collapse and expand videos in chat", async function (assert) {
|
|
const videoContainer =
|
|
".chat-message-container[data-id='1'] .lazy-video-container";
|
|
const expandImage =
|
|
".chat-message-container[data-id='1'] .chat-message-collapser-closed";
|
|
const collapseImage =
|
|
".chat-message-container[data-id='1'] .chat-message-collapser-opened";
|
|
|
|
await visit("/chat/c/cat/1");
|
|
|
|
assert.dom(videoContainer).isVisible();
|
|
assert.dom(collapseImage).isVisible("the open arrow is shown");
|
|
assert.dom(expandImage).isNotVIsible("the close arrow is hidden");
|
|
|
|
await click(collapseImage);
|
|
|
|
assert.dom(videoContainer).isNotVisible();
|
|
assert.dom(expandImage).isVisible("the close arrow is shown");
|
|
assert.dom(collapseImage).isNotVIsible("the open arrow is hidden");
|
|
|
|
await click(expandImage);
|
|
|
|
assert.dom(videoContainer).isVisible();
|
|
assert.dom(collapseImage).isVisible("the open arrow is shown again");
|
|
assert.dom(expandImage).isNotVIsible("the close arrow is hidden again");
|
|
});
|
|
|
|
skip("lightbox shows up before and after expand and collapse", async function (assert) {
|
|
const image = ".chat-message-container[data-id='2'] .chat-img-upload";
|
|
const expandImage =
|
|
".chat-message-container[data-id='2'] .chat-message-collapser-closed";
|
|
const collapseImage =
|
|
".chat-message-container[data-id='2'] .chat-message-collapser-opened";
|
|
|
|
await visit("/chat/c/cat/1");
|
|
|
|
await click(image);
|
|
|
|
assert.dom(".mfp-img").exists("can see lightbox");
|
|
await click(".mfp-container");
|
|
|
|
await click(collapseImage);
|
|
await click(expandImage);
|
|
|
|
await click(image);
|
|
assert.dom(".mfp-img").exists("can see lightbox after collapse expand");
|
|
await click(".mfp-container");
|
|
});
|
|
});
|