Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-04 06:28:47 +08:00
Code Packages Activity Actions
discourse/plugins/discourse-local-dates/spec
History
Exact
Régis Hanol 53b3d2f0dc FIX: BBCode tag parser 
Wasn't quite handling the cases where a closing bracket `]` was used in the value of one of the attributes.

```markdown
[chat quote=user channel="[broken]"]
```

Would not be correctly parsed because we would _greedily_ use the first `]` as the end of the tag even though it might be a valid character when inside proper quotes.

c39a4de139/app/assets/javascripts/discourse-markdown-it/src/features/bbcode-block.js (L62)

Re-wrote the `parseBBCodeTag` to properly handle the following cases

- A closing tag (aka `[/name]`) which are easy since they don't have any attributes
- An old `[quote=...]` format we used that doesn't uses quotes but still has various attributes of the form `key:value`
- All three valid BBCode opening tag formats we support
  - `[name]` without any attributes
  - `[name=foo]` with a default value
  - `[name foo=bar]` with some attributes

Ended up having to fix/rewrite the few bbcode rules that were using the `parseBBCodeTag` function, namely `d-wrap` and `discourse-local-dates`.

While working on this, I think I also found a way to get rid the of shims we had in place so that plugins could use the `parseBBCodeTag` function.

Reference - https://meta.discourse.org/t/having-a-right-bracket-in-a-channel-name-breaks-all-quotes-from-that-channel/308439
2024-06-18 10:47:18 +02:00
..
integration FIX: missing IST KST and JST timezones in cooked posts (#26252) 2024-03-20 11:28:45 +11:00
lib FIX: BBCode tag parser 2024-06-18 10:47:18 +02:00
models DEV: Apply syntax_tree formatting to plugins/* 2023-01-07 11:11:37 +00:00
system FEATURE: Redesigned bookmark modal and menu (#23071) 2024-04-05 09:25:30 +10:00