0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-11 02:59:07 +08:00
discourse/spec/services/site_setting_localizations/about_config/show_spec.rb
Natalie Tay af11f8992c
FEATURE: Localizable /about page fields via its settings page (#41123)
The /about page (unlike /guidelines or /tos) is not backed by a topic,
but instead via a bunch of site settings.

If it were backed by a topic, localization would be easy as it can just
use TopicLocalizations. We also can't swap it out to use a topic, since
there are so many fields on the about page that can't be safely
contained in a topic.

----------

This PR adds SiteSettingLocalization, allowing new attributes in site
settings config for localization.

For now this is wired into the About page settings flow:
  - admins can select a non-default locale on /admin/config/about
  - only translatable About fields are shown for that locale
  - localized About values are used on /about and /about.json
- company_url can be set manually per locale, but is excluded from
automatic translation
- ~~AI backfill can translate eligible site setting localizations~~ no
backfill (added in
https://github.com/discourse/discourse/pull/41123/commits/386c655d2f44aca54440c069bd06ea8007793d84,
removed in
https://github.com/discourse/discourse/pull/41123/commits/6f8ec9cc43dca4195bda638b1ce980eb68a59941.
about page has very non automa-ble fields

This intentionally keeps the scope narrow. It does not make every site
setting localizable, and any other setting can be localized by adding to
that allowlist.

Some screenshots

|page | 📸  | 
|--|--|
| eng setting | <img width="1278" height="871" alt="Screenshot
2026-06-23 at 11 00 34 PM"
src="https://github.com/user-attachments/assets/59431464-fb05-41d9-8c4f-fd9aae7fb45f"
/>
| ja setting | <img width="1278" height="871" alt="Screenshot 2026-06-23
at 11 01 20 PM"
src="https://github.com/user-attachments/assets/73cd2878-f59a-4dc4-a76d-2f46b74a6eed"
/>
| ja anon about page | <img width="1278" height="871" alt="Screenshot
2026-06-23 at 11 01 48 PM"
src="https://github.com/user-attachments/assets/02464a5f-9ca0-4519-9521-be41498c1967"
/>
2026-06-26 20:41:08 +08:00

73 lines
1.9 KiB
Ruby
Vendored

# frozen_string_literal: true
describe SiteSettingLocalizations::AboutConfig::Show do
describe described_class::Contract, type: :model do
it { is_expected.to validate_presence_of(:locale) }
end
describe ".call" do
subject(:result) { described_class.call(params:, **dependencies) }
fab!(:admin)
fab!(:user)
let(:params) { { locale: } }
let(:dependencies) { { guardian: } }
let(:guardian) { admin.guardian }
let(:locale) { "ja" }
before do
SiteSetting.content_localization_enabled = true
SiteSetting.content_localization_supported_locales = "ja|pt_BR"
end
context "when locale is blank" do
let(:locale) { nil }
it { is_expected.to fail_a_contract }
end
context "when the user is not an admin" do
let(:guardian) { user.guardian }
it { is_expected.to fail_a_policy(:can_localize_site_settings) }
end
context "when content localization is disabled" do
before { SiteSetting.content_localization_enabled = false }
it { is_expected.to fail_a_policy(:can_localize_site_settings) }
end
context "with an unsupported locale" do
let(:locale) { "de" }
it { is_expected.to fail_a_policy(:locale_is_supported) }
end
context "when everything is ok" do
before do
SiteSettingLocalization.create!(setting_name: "title", locale: "ja", value: "日本語タイトル")
SiteSettingLocalization.create!(
setting_name: "site_description",
locale: "pt_BR",
value: "Descrição",
)
end
it { is_expected.to run_successfully }
it "returns the localized about settings" do
expect(result.payload).to eq(
locale: "ja",
localizations: {
"title" => {
value: "日本語タイトル",
cooked: nil,
},
},
)
end
end
end
end