Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-21 12:49:23 +08:00
Code Packages Activity Actions
discourse/lib/file_store
History
Exact
Alan Guo Xiang Tan 342e9208b3
FIX: Upload#update_secure_status not updating s3 access control (#33232) 
This commit is a follow-up to b02bc707de
where `Upload#update_secure_status` does not call
`FileStore::S3Store#update_upload_access_control` if
`s3_use_acls` is disabled. This is no longer correct as an upload's
access control on S3 can now be based on tags if the
`s3_enable_access_control_tags` site setting is
enabled.

To fix this, this commit removes the `s3_use_acls` check in
`Upload#update_secure_status` and updates
`FileStore::S3Store#default_s3_options`
to not set the `acl` option if the `s3_use_acls` site setting is
disabled.
2025-06-17 16:28:36 +08:00
..
base_store.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
local_store.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
s3_store.rb FIX: Upload#update_secure_status not updating s3 access control (#33232) 2025-06-17 16:28:36 +08:00
to_s3_migration.rb DEV: Add setting to tag s3 objects enabling tag based access control policies (#32988) 2025-06-16 13:26:18 +08:00