Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-13 12:17:15 +08:00
Code Packages Activity Actions
discourse/app/assets/javascripts/dialog-holder/addon/components
History
Exact
David Taylor 579eda6b66
DEV: Move dialog DOM handling from service to component (#31925) 
Accessing a component-rendered DOM element from a service is not ideal,
and can lead to timing issues. We've attempted to work around this using
`afterRender`, but it's still not ideal.

This commit moves the `A11YDialog` setup into a modifier. Now the
service only stores state, and the component renders things based on
that state. This is much more in line with Ember norms, and should be
much more robust.

Test adjustments are because the dialog element is now only rendered
on-demand, rather than being present in the DOM all the time. This
brings dialog inline with our Modal system.
2025-03-21 08:59:23 +08:00
..
dialog-holder.gjs DEV: Move dialog DOM handling from service to component (#31925) 2025-03-21 08:59:23 +08:00