0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-04 10:39:43 +08:00
discourse/plugins/discourse-topic-voting/spec
Alan Guo Xiang Tan 6df9b0b357
DEV: Prefer RSpec primitives for test setup (#42122)
RSpec setup becomes harder to follow at either extreme: trivial fixture
wrappers hide lifecycle and intent, while forcing every named operation
inline repeats low-level protocol and configuration details.

This change documents and applies a test-setup hierarchy:

- use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according
to lifecycle and role;
- use a small example-group method when parameterized behavior gives one
spec useful vocabulary;
- move helpers into auto-loaded `spec/support` only when they are shared
across spec files;
- use fabricators and page objects for the data shapes and system-test
interfaces they own.

Core and plugin support files are loaded centrally by `rails_helper`, so
plugin-specific support loaders are unnecessary. The migration specs
encountered during the sweep are removed according to repository policy;
production migrations are unchanged.
2026-07-30 11:17:22 +08:00
..
fabricators
integration DEV: Prefer RSpec primitives for test setup (#42122) 2026-07-30 11:17:22 +08:00
jobs DEV: Prefer RSpec primitives for test setup (#42122) 2026-07-30 11:17:22 +08:00
lib DEV: Prefer RSpec primitives for test setup (#42122) 2026-07-30 11:17:22 +08:00
requests FEATURE: Promote Ideas & Events category types to permanent status (#42080) 2026-07-29 09:20:40 +10:00
serializers DEV: Don't use fab! for non-ActiveRecord model objects (#39272) 2026-04-15 00:52:34 +02:00
services/discourse_topic_voting DEV: Prefer RSpec primitives for test setup (#42122) 2026-07-30 11:17:22 +08:00
system FEATURE: Promote Ideas & Events category types to permanent status (#42080) 2026-07-29 09:20:40 +10:00
ensure_consistency_spec.rb
voting_spec.rb FIX: Show the voting notification prompt when vote limits are disabled (#41731) 2026-07-15 14:54:37 +02:00