mirror of
https://github.com/discourse/discourse.git
synced 2026-08-04 10:39:43 +08:00
RSpec setup becomes harder to follow at either extreme: trivial fixture wrappers hide lifecycle and intent, while forcing every named operation inline repeats low-level protocol and configuration details. This change documents and applies a test-setup hierarchy: - use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according to lifecycle and role; - use a small example-group method when parameterized behavior gives one spec useful vocabulary; - move helpers into auto-loaded `spec/support` only when they are shared across spec files; - use fabricators and page objects for the data shapes and system-test interfaces they own. Core and plugin support files are loaded centrally by `rails_helper`, so plugin-specific support loaders are unnecessary. The migration specs encountered during the sweep are removed according to repository policy; production migrations are unchanged.
158 lines
4.6 KiB
Ruby
Vendored
158 lines
4.6 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe User do
|
|
let(:user) { Fabricate(:user) }
|
|
let(:profile_page_url) { "#{Discourse.base_url}/users/#{user.username}" }
|
|
let(:i18n_post_args) { { base_uri: "" } }
|
|
|
|
before do
|
|
stub_image_size
|
|
Jobs.run_immediately!
|
|
SiteSetting.discourse_narrative_bot_enabled = true
|
|
SiteSetting.disable_discourse_narrative_bot_welcome_post = false
|
|
end
|
|
|
|
describe "when a user is created" do
|
|
it "should initiate the bot" do
|
|
NotificationEmailer.expects(:process_notification).never
|
|
|
|
user
|
|
|
|
expected_raw =
|
|
I18n.t(
|
|
"discourse_narrative_bot.new_user_narrative.hello.message",
|
|
**i18n_post_args,
|
|
username: user.username,
|
|
title: SiteSetting.title,
|
|
)
|
|
|
|
expect(Post.last.raw).to include(expected_raw.chomp)
|
|
end
|
|
|
|
describe "welcome post" do
|
|
context "when disabled" do
|
|
before { SiteSetting.disable_discourse_narrative_bot_welcome_post = true }
|
|
|
|
it "should not initiate the bot" do
|
|
expect { user }.to_not change { Post.count }
|
|
end
|
|
end
|
|
|
|
context "with title emoji disabled" do
|
|
before do
|
|
SiteSetting.disable_discourse_narrative_bot_welcome_post = false
|
|
SiteSetting.max_emojis_in_title = 0
|
|
end
|
|
|
|
it "initiates the bot" do
|
|
expect { user }.to change { Topic.count }.by(1)
|
|
|
|
expect(Topic.last.title).to eq(
|
|
I18n
|
|
.t("discourse_narrative_bot.new_user_narrative.hello.title", **i18n_post_args)
|
|
.gsub(/:robot:/, "")
|
|
.strip,
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when enabled" do
|
|
before { SiteSetting.disable_discourse_narrative_bot_welcome_post = false }
|
|
|
|
it "initiate the bot" do
|
|
expect { user }.to change { Topic.count }.by(1)
|
|
|
|
expect(Topic.last.title).to eq(
|
|
I18n.t("discourse_narrative_bot.new_user_narrative.hello.title", **i18n_post_args),
|
|
)
|
|
end
|
|
|
|
describe "when send welcome message is selected" do
|
|
before { SiteSetting.discourse_narrative_bot_welcome_post_type = "welcome_message" }
|
|
|
|
it "should send the right welcome message" do
|
|
expect { user }.to change { Topic.count }.by(1)
|
|
|
|
expect(Topic.last.title).to eq(
|
|
I18n.t(
|
|
"system_messages.welcome_user.subject_template",
|
|
**i18n_post_args,
|
|
site_name: SiteSetting.title,
|
|
),
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "when welcome message is configured to be delayed" do
|
|
before { SiteSetting.discourse_narrative_bot_welcome_post_delay = 100 }
|
|
|
|
it "should delay the welcome post until user logs in" do
|
|
user
|
|
|
|
expect(Jobs::NarrativeInit.jobs.count).to eq(0)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when user is staged" do
|
|
let(:user) { Fabricate(:user, staged: true) }
|
|
|
|
it "should not initiate the bot" do
|
|
expect { user }.to_not change { Post.count }
|
|
end
|
|
end
|
|
|
|
context "when user skipped the new user tips" do
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
it "should not initiate the bot" do
|
|
SiteSetting.default_other_skip_new_user_tips = true
|
|
expect { user }.to_not change { Post.count }
|
|
end
|
|
end
|
|
|
|
context "when user is anonymous?" do
|
|
before { SiteSetting.allow_anonymous_mode = true }
|
|
|
|
it "should initiate bot for real user only" do
|
|
user = Fabricate(:user, trust_level: 1)
|
|
Group.refresh_automatic_groups!
|
|
shadow = AnonymousShadowCreator.get(user)
|
|
|
|
expect(TopicAllowedUser.where(user_id: shadow.id).count).to eq(0)
|
|
expect(TopicAllowedUser.where(user_id: user.id).count).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "when user's username should be ignored" do
|
|
let(:user) { Fabricate.build(:user) }
|
|
|
|
before { SiteSetting.discourse_narrative_bot_ignored_usernames = "discourse|test" }
|
|
|
|
%w[discourse test].each do |username|
|
|
it "should not initiate the bot" do
|
|
expect { user.update!(username: username) }.to_not change { Post.count }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "when a user has been destroyed" do
|
|
it "should clean up plugin's store" do
|
|
DiscourseNarrativeBot::Store.set(user.id, "test")
|
|
|
|
user.destroy!
|
|
|
|
expect(DiscourseNarrativeBot::Store.get(user.id)).to eq(nil)
|
|
end
|
|
end
|
|
|
|
describe "#manually_disabled_discobot?" do
|
|
it "returns true if the user manually disabled new user tips" do
|
|
user.user_option.skip_new_user_tips = true
|
|
|
|
expect(user.manually_disabled_discobot?).to eq(true)
|
|
end
|
|
end
|
|
end
|