mirror of
https://github.com/discourse/discourse.git
synced 2026-08-05 15:18:34 +08:00
63c4950c90## What Draft spike for rendering nested replies through the normal topic route/controller/template (`/t/:slug/:id[/post_number]`) instead of a separate Ember `/n/...` browser page route. This keeps `/n/...` for internal JSON/API endpoints and legacy browser redirects, while using the canonical topic route for user-facing nested topic navigation. ## Changes - Add nested-topic loading/setup to `topic.fromParams` so `/t/...` can render the nested tree. - Render `<Nested>` from the topic template when the topic is in nested mode. - Keep the nested controller as the nested tree state owner, bridged from the topic route/controller. - Redirect legacy client-side `/n/...` browser routes to the corresponding `/t/...` routes. - Preserve nested context depth through model processing, controller state, and cache snapshots. - Update nested post/admin URLs, notifications, activity, copy links, and system specs to canonical `/t/...` browser URLs. - Split scroll-anchor persistence from full nested model cache snapshots to avoid expensive cache writes on scroll. - Add bounded scroll restoration retries for mobile browser-back focus restoration.
77 lines
2.1 KiB
Ruby
Vendored
77 lines
2.1 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Nested view cloaking" do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:topic) { Fabricate(:topic, user: user) }
|
|
fab!(:op) { Fabricate(:post, topic: topic, user: user, post_number: 1) }
|
|
|
|
let(:nested_view) { PageObjects::Pages::NestedView.new }
|
|
|
|
before do
|
|
SiteSetting.nested_replies_enabled = true
|
|
Fabricate(:nested_topic, topic: topic)
|
|
sign_in(user)
|
|
end
|
|
|
|
context "with many root posts" do
|
|
before do
|
|
20.times do |i|
|
|
root =
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Root post number #{i + 1} with enough content to take up space",
|
|
)
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply to root #{i + 1}",
|
|
reply_to_post_number: root.post_number,
|
|
)
|
|
end
|
|
end
|
|
|
|
it "cloaks root subtrees far from the viewport" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_nested_view
|
|
|
|
expect(nested_view).to have_cloaked_root
|
|
|
|
expect(page).to have_no_css(
|
|
".nested-view__roots > .nested-post:first-child.nested-post--cloaked",
|
|
)
|
|
end
|
|
|
|
it "uncloaks roots when scrolling to them" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_nested_view
|
|
|
|
send_keys(:end)
|
|
|
|
expect(page).to have_css(
|
|
".nested-view__roots > .nested-post:first-child.nested-post--cloaked",
|
|
wait: 5,
|
|
)
|
|
|
|
send_keys(:home)
|
|
|
|
expect(page).to have_no_css(
|
|
".nested-view__roots > .nested-post:first-child.nested-post--cloaked",
|
|
)
|
|
end
|
|
|
|
it "hides children content when root is cloaked" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_nested_view
|
|
|
|
expect(page).to have_no_css(
|
|
".nested-view__roots > .nested-post--cloaked .nested-post__article",
|
|
)
|
|
expect(page).to have_no_css(
|
|
".nested-view__roots > .nested-post--cloaked .nested-post-children",
|
|
)
|
|
end
|
|
end
|
|
end
|
